Fix nightly GPU failures after kokkos 4.5.0 #1100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- remove create_copy() and create temp workspace - add Helmholtz back in
jewatkins
added
the
Testing
mperego
approved these changes
Dec 13, 2024
it looks like there's a Helmholtz Teko test I can try to revive too. I'll leave that for another time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #1097. The residual was fine but the Jacobian was zero. I had to backtrack to this routine: https://github.com/sandialabs/Albany/compare/jewatkins/fix-cudauvm-build?expand=1#diff-b8f4f1c28bdb086398fa7e2b2af2ff512bc8dc3df7c5af97e4979760004e8fdeL132
where derivative components were not being computed properly.
create_copy()is not really needed and looks a bit hacky (also it's not tested and probably not worth fixing). It seems easier to just allocate some memory for these temp fields.Also, it looks like Helmholtz2D was removed, so I added that back in. I traced the removal back to cbca814 based on this issue: #840 and this wiki doc: https://acme-climate.atlassian.net/wiki/spaces/FAN/pages/3539469051/Albany+tests+and+problems+re-organization
which says we want to keep it around.