Organization and cleaning of tests and problems. Phase 2: rearrangement #870
Conversation
src/CMakeLists.txt
Outdated
| @@ -44,6 +43,7 @@ set (ALBANY_INCLUDE_DIRS | |||
| ${Albany_SOURCE_DIR}/src/disc/stk | |||
| ${Albany_SOURCE_DIR}/src/disc | |||
| ${Albany_SOURCE_DIR}/src/utility | |||
| ${Albany_SOURCE_DIR}/src/corePDEs/evaluators | |||
There was a problem hiding this comment.
A small nitpick but I would probably call this directory CorePDEs and the other one DemoPDEs to stick with the very loose convention of using CamelCase (e.g. LandIce). Probably better than using snake_case which is used for all other directories so we avoid having to change LandIce.
|
My browser cannot handle the large number of files to diff, and hangs. I agree with Jerry that making case uniform looks cleaner. I'm ok with the reorg. |
|
Thanks @bartgol and @jewatkins. I'm ok using CamelCase, but then for consistency we should change all the other folders? ( |
|
Ugh, yeah, that's annoying. And lower case is easier when typing and autocompleting. I am ok with whatever you pick then. Btw, if you wanted to change |
mperego
changed the title
|
As long as everyone's okay with changing LandIce to landice or land_ice then that's probably the easier option. I was thinking corePDEs was camelCase. Would it then be |
|
We could do camelCase and have |
|
That works too. |
|
camelCase is okay. I think at least the interface dirs would have to be changed: landIce/interfaceWithMPAS |
Now we have three main test folders: unit corePDEs demoPDEs LandIce The test names have changed to include the name of folders they belong to. We removed the small/large folders, however, large tests are run only when they are enabled at configuration. We removed the performance test, as now we handle performance tests in a different repo
mperego
force-pushed
the
test_rearrangement
branch
from
b4c5cfd to
72e57c5
Compare
|
b.t.w. also the LandIce tests change name, because we are pre-pending landIce to their current names (and fix a few inconsistencies) |
Created folders src/corePDEs src/demoPDEs and move corresponding evaluators and problems to these folders. Removed files that were not used
mperego
force-pushed
the
test_rearrangement
branch
from
72e57c5 to
3f311fd
Compare
This is part of the work to reorganize Albany folders and tests, see here and follows PR #854.
In particular the new tests structure is
Tests always have in the name one of the above folder, so that it's easy to identify where they belong.
We got rid of the distinction between small and large tests, however, large tests can be built optionally as before.
Remove a couple of tests that are no longer relevant, in particular the Performance tests (We have another repo now for performance testing).
The source folder has been re-organized as well as follows
Evaluators that are no longer used have been removed.
This is only a proposed change, we can discuss tomorrow at the Albany meeting what we prefer to do.
Also, we need to manage conflicts with the DofManager PR. (An option would be to split this PR in two, one addressing the test refactor and one the source refactor and start merging only the test refactor PR).