Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing errors in dissimilarity matrix creation #14

Merged
merged 1 commit into from
Mar 13, 2024
Merged

Conversation

ThomasWomack
Copy link
Collaborator

@ThomasWomack ThomasWomack commented Feb 21, 2024

Description

Fixing errors in dissimilarity matrix creation

Was accidentally comparing node type to itself, instead of the type of the other node.
The code to find the set of outgoing edge neighbors was also incorrect.

Motivation and Context

The dissimilarity matrix creation did not work as intended or documented before.

How has this been tested?

Yes

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@ThomasWomack ThomasWomack requested a review from tgunda February 21, 2024 22:46
@tgunda tgunda merged commit a6f9aac into main Mar 13, 2024
18 checks passed
@tgunda tgunda deleted the graph_tutorial_fr_fix branch March 13, 2024 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants