chore!: Drop support for Python 3.8

[jmgate]

Type: Task

Description

• Use the type-hinting provided out of the box in 3.9.
• Remove version guards around argparse.BooleanOptionalAction.
• Update documentation and CI accordingly.

Related Issues/PRs

• Closes Drop Support for Python 3.8 #15.
• After this is merged, ci: pre-commit auto-update #242 should pass CI.

Motivation

Python 3.8 is no longer supported by the community.

Summary by Sourcery

Drop support for Python 3.8, leveraging Python 3.9 features such as built-in type hinting and removing version guards for BooleanOptionalAction. Update CI and documentation to align with the new minimum Python version requirement.

Enhancements:

• Utilize Python 3.9's built-in type hinting capabilities.

CI:

• Update CI configuration to remove testing for Python 3.8.

Documentation:

• Update documentation to reflect the removal of Python 3.8 support.

Chores:

• Drop support for Python 3.8 across the codebase.

[sourcery-ai]

Reviewer's Guide by Sourcery

This PR removes Python 3.8 support from the project by leveraging Python 3.9+ features, particularly focusing on built-in type hints and the BooleanOptionalAction from argparse. The implementation involves removing version checks, updating type hints, and adjusting CI configuration and documentation.

Updated class diagram for ReverseArgumentParser

classDiagram
    class ReverseArgumentParser {
        - list[str] _args
        - int _indent
        - Namespace _namespace
        - list[ArgumentParser] _parsers
        - list[bool] _unparsed
        + _unparse_action(Action action) void
        + get_pretty_command_line_invocation() str
        + _get_long_option_strings(Sequence~str~ option_strings) list[str]
        + _get_short_option_strings(Sequence~str~ option_strings) list[str]
        + _append_list_of_list_of_args(list[list[str]] args) void
        + _append_list_of_args(list[str] args) void
    }

Loading

File-Level Changes

Change	Details	Files
Remove Python 3.8 version checks and directly use BooleanOptionalAction	Remove sys.version_info checks for BooleanOptionalAction Remove BOOLEAN_OPTIONAL_ACTION_MINOR_VERSION constant Simplify conditional logic in test assertions Update argument parser implementation to use BooleanOptionalAction directly	test/test_reverse_argparse.py reverse_argparse/reverse_argparse.py
Update type hints to use Python 3.9+ syntax	Replace List[] with list[] annotations Remove typing imports for built-in containers	reverse_argparse/reverse_argparse.py
Update project metadata and CI configuration	Remove Python 3.8 from CI matrix Update Python version badge in README Remove Python 3.8 classifier from pyproject.toml	.github/workflows/continuous-integration.yml README.md pyproject.toml

Assessment against linked issues

Issue	Objective	Addressed	Explanation
#15	Update configuration files (pyproject.toml, README.md, CI) to remove Python 3.8 support	✅
#15	Remove version guards around BooleanOptionalAction and use Python 3.9+ features	✅
#15	Update type hints to use Python 3.9+ syntax	✅

Possibly linked issues

• Drop Support for Python 3.8 #15: The PR implements all tasks listed in the issue for dropping Python 3.8 support.

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time. You can also use
  this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey @jmgate - I've reviewed your changes and they look great!

Here's what I looked at during the review

• 🟢 General issues: all looks good
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.97%. Comparing base (65aa685) to head (5c448ec).
Report is 2 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #244      +/-   ##
==========================================
- Coverage   94.04%   93.97%   -0.08%     
==========================================
  Files           2        2              
  Lines         168      166       -2     
  Branches       42       37       -5     
==========================================
- Hits          158      156       -2     
  Misses          4        4              
  Partials        6        6              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[jmgate]

@jcox10, @GhostofGoes, @william76, anyone want to review and approve?

[GhostofGoes]

LGTM