make tests compatible with setuptools_scm 8+ #57
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@webknjaz, workflows need approval. |
webknjaz
force-pushed
the
ssm8
branch
2 times, most recently
from
fbb4fd0 to
8b30d21
Compare
webknjaz
reviewed
Nov 4, 2023
| @@ -131,7 +134,9 @@ def test_get_version_from_scm_tag_in_git_repo( | |||
| git_cmd, git_commit_cmd, git_tag_cmd, | |||
| ): | |||
| """Check that get_version_from_scm_tag works properly in Git repo.""" | |||
| assert get_self_version() == '0.1.dev0' | |||
| # setuptools_scm 8+ includes a date stamp here. | |||
There was a problem hiding this comment.
I'd like to understand if there's a parameter we can set that would normalize its behavior and keep it as it was...
These changes address incompatibilities introduced in setuptools_scm 8 that affect the utils.versiontools unit tests.
|
Those tests were checking the helper producing the version for packaging metadata. Now, the packaging has been updated not to use it so I dropped it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes address incompatibilities introduced in setuptools_scm 8
that affect the utils.versiontools unit tests.