Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(listener): add support for includeAllVersions #1003

Merged
merged 2 commits into from
Feb 11, 2025
Merged

feat(listener): add support for includeAllVersions #1003

merged 2 commits into from
Feb 11, 2025

Conversation

bjoerge
Copy link
Member

@bjoerge bjoerge commented Feb 5, 2025 •
edited
Loading

Adds support for passing the includeAllVersions param to client.listen(). Docs TBD

bjoerge
bjoerge commented Feb 5, 2025
View reviewed changes
src/types.ts Outdated Show resolved Hide resolved
@bjoerge bjoerge requested a review from rneatherway February 5, 2025 11:01
@bjoerge bjoerge force-pushed the add-include-all-version-param branch from d0a143f to 20a44bf Compare February 6, 2025 18:32
@bjoerge bjoerge force-pushed the add-include-all-version-param branch from 91f7ce3 to 00f476a Compare February 10, 2025 13:43
@bjoerge bjoerge force-pushed the add-include-all-version-param branch 2 times, most recently from 82352ef to 4b27e17 Compare February 10, 2025 13:57
@bjoerge
Copy link
Member Author

bjoerge commented Feb 10, 2025

This is now good to go. This will merely just forward the includeAllVersions param, which is marked as internal for now. The API docs can come later.

@bjoerge bjoerge marked this pull request as ready for review February 10, 2025 14:01
rneatherway
rneatherway approved these changes Feb 11, 2025
View reviewed changes
Copy link
Contributor

@rneatherway rneatherway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bjoerge bjoerge added this pull request to the merge queue Feb 11, 2025
Merged via the queue into main with commit fff3a76 Feb 11, 2025
23 of 24 checks passed
@bjoerge bjoerge deleted the add-include-all-version-param branch February 11, 2025 11:21
@ecospark ecospark bot mentioned this pull request Feb 11, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rneatherway rneatherway rneatherway approved these changes

@stipsan stipsan Awaiting requested review from stipsan

@pedrobonamin pedrobonamin Awaiting requested review from pedrobonamin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bjoerge @rneatherway