-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support react 19, upgrade build tooling #111
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM! There are some failing tests and something something snyk that needs to be cleaned up before merge.
"sanity-extra": "^1.0.0", | ||
"sanity-testing-library": "^1.0.0", | ||
"semantic-release": "^22.0.0", | ||
"sanity": "^3.67.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It never occurred to me to just do this. So simple, yet so effective.
devDep sanity and a selfcontained sanity.config.ts– so smooth 👍
This is the way plugin-kit should ship.
Upgrading the build tooling and dependencies lead to a number of lint errors that I had to go through and fix, thus the large diff. I had to get rid of the workshop - it was crashing, and has a bunch of peer dependency issues that needs to be resolved if we want to continue using it. For now I just added a stripped down studio with an editor utilizing the input.