-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Edit thumbnail #400
base: main
Are you sure you want to change the base?
feat: Edit thumbnail #400
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
@R-Delfino95 is attempting to deploy a commit to the Sanity Sandbox Team on Vercel. A member of the Team first needs to authorize it. |
Hi! Thank you for setting this up! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi!
Thank you so much once more for doing this!
The only thing that I would bring up which I found strange (but it's fine, I just wondered if it's expected), is that when I change the thumbnail two things don't happen:
- I am not prompted to publish the changes
- It doesn't change the thumbnail on the actual UI, only on the studio input (see video)
Screen.Recording.2025-02-05.at.13.22.57.mov
I'm assuming this is the intended behaviour but I just want to double check :)
Hi! Thanks for reviewing the PR. The thumbnail functionality is internal to Sanity Studio. As @decepulis mentioned, MUX does not support storing the thumbnail time, so it is simply a value stored in the If you want to use the thumbnail elsewhere, you would need to get that value from Sanity documents and apply it in your UI. Let me know your thoughts! |
Related to #321
thumbTime
in themux.videoAsset
document.Here are some images and a recording of the result:
recording.mp4