fix(core): fix typing-issues related to GlobalDocumentReferenceInput

sanity-io · Jan 30, 2025 · 293a6b8 · 293a6b8
1 parent b77e987
commit 293a6b8
Show file tree

Hide file tree

Showing 6 changed files with 8 additions and 8 deletions.
diff --git a/...sanity/src/core/form/inputs/GlobalDocumentReferenceInput/GlobalDocumentReferenceInput.tsx b/...sanity/src/core/form/inputs/GlobalDocumentReferenceInput/GlobalDocumentReferenceInput.tsx
@@ -8,6 +8,7 @@ import {Box, Card, Flex, Inline, Menu, Stack, useClickOutsideEvent, useToast} fr
 import {
   type FocusEvent,
   type KeyboardEvent,
+  type ReactNode,
   useCallback,
   useId,
   useMemo,
@@ -56,9 +57,7 @@ const NO_FILTER = () => true
 const REF_PATH = ['_ref']
 
 /** @internal */
-export function GlobalDocumentReferenceInput(
-  props: GlobalDocumentReferenceInputProps,
-): JSX.Element {
+export function GlobalDocumentReferenceInput(props: GlobalDocumentReferenceInputProps): ReactNode {
   const {
     changed,
     focused,

diff --git a/...nity/src/core/form/inputs/GlobalDocumentReferenceInput/GlobalDocumentReferencePreview.tsx b/...nity/src/core/form/inputs/GlobalDocumentReferenceInput/GlobalDocumentReferencePreview.tsx
@@ -29,7 +29,7 @@ export function GlobalDocumentReferencePreview(props: {
   resourceId: string
   refType?: GlobalDocumentReferenceType
   showTypeLabel: boolean
-}): JSX.Element {
+}): React.JSX.Element {
   const {
     refType,
     showStudioUrlIcon,

diff --git a/packages/sanity/src/core/form/inputs/GlobalDocumentReferenceInput/OptionPreview.tsx b/packages/sanity/src/core/form/inputs/GlobalDocumentReferenceInput/OptionPreview.tsx
@@ -1,5 +1,6 @@
 import {type GlobalDocumentReferenceSchemaType} from '@sanity/types'
 import {Stack, Text, TextSkeleton} from '@sanity/ui'
+import {type ReactNode} from 'react'
 import {type Observable} from 'rxjs'
 
 import {useTranslation} from '../../../i18n'
@@ -19,7 +20,7 @@ export function OptionPreview(props: {
   document: {_id: string; _type: string}
   referenceType: GlobalDocumentReferenceSchemaType
   getReferenceInfo: (doc: {_id: string; _type?: string}) => Observable<GlobalDocumentReferenceInfo>
-}): JSX.Element | null {
+}): ReactNode {
   const {
     isLoading,
     result: referenceInfo,

diff --git a/packages/sanity/src/core/form/inputs/GlobalDocumentReferenceInput/PreviewReferenceValue.tsx b/packages/sanity/src/core/form/inputs/GlobalDocumentReferenceInput/PreviewReferenceValue.tsx
@@ -15,7 +15,7 @@ export function PreviewReferenceValue(props: {
   hasStudioUrl?: boolean
   type: GlobalDocumentReferenceSchemaType
   referenceInfo: Loadable<GlobalDocumentReferenceInfo>
-}): JSX.Element {
+}): React.JSX.Element {
   const {value, type, showStudioUrlIcon, hasStudioUrl, referenceInfo} = props
   const {t} = useTranslation()
 

diff --git a/packages/sanity/src/core/form/inputs/GlobalDocumentReferenceInput/ReferenceAutocomplete.tsx b/packages/sanity/src/core/form/inputs/GlobalDocumentReferenceInput/ReferenceAutocomplete.tsx
@@ -30,7 +30,7 @@ export const ReferenceAutocomplete = forwardRef(function ReferenceAutocomplete(
   props: ComponentProps<typeof Autocomplete> & {
     referenceElement: HTMLDivElement | null
     searchString?: string
-    portalRef?: RefObject<HTMLDivElement>
+    portalRef?: RefObject<HTMLDivElement | null>
   },
   ref: ForwardedRef<HTMLInputElement>,
 ) {

diff --git a/...rc/core/form/studio/inputs/globalDocumentReference/StudioGlobalDocumentReferenceInput.tsx b/...rc/core/form/studio/inputs/globalDocumentReference/StudioGlobalDocumentReferenceInput.tsx
@@ -77,7 +77,7 @@ type SearchError = {
  */
 export function StudioGlobalDocumentReferenceInput(
   props: StudioGlobalDocumentReferenceInputProps,
-): JSX.Element {
+): React.JSX.Element {
   const {path, schemaType} = props
   const source = useSource()
   const client = source.getClient({