Skip to content

Commit

Permalink
fix: forego dep check and remove framework parameter
Browse files Browse the repository at this point in the history
  • Loading branch information
cngonzalez committed Feb 4, 2025
1 parent 08d7370 commit 40923aa
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ import {defineCliConfig} from 'sanity/cli'
export default defineCliConfig({
__experimental_coreAppConfiguration: {
framework: 'vite',
appLocation: '%appLocation%'
},
})
Expand Down
1 change: 0 additions & 1 deletion packages/@sanity/cli/src/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -351,7 +351,6 @@ export interface CliConfig {
* @internal
*/
__experimental_coreAppConfiguration?: {
framework: 'vite' // add others as we make them available, e.g., 'vite' | 'vue'
appLocation?: string
}
}
Expand Down
8 changes: 5 additions & 3 deletions packages/sanity/src/_internal/cli/actions/dev/devAction.ts
Original file line number Diff line number Diff line change
Expand Up @@ -31,9 +31,11 @@ export default async function startSanityDevServer(
timers.end('checkStudioDependencyVersions')

// If the check resulted in a dependency install, the CLI command will be re-run,
// thus we want to exit early
if ((await checkRequiredDependencies(context)).didInstall) {
return
// thus we want to exit early (only for studios)
if (!(cliConfig && '__experimental_coreAppConfiguration' in cliConfig)) {
if ((await checkRequiredDependencies(context)).didInstall) {
return
}
}

// Try to load CLI configuration from sanity.cli.(js|ts)
Expand Down

0 comments on commit 40923aa

Please sign in to comment.