fix(core): make revisionId required in getDocumentAtRevision

sanity-io · Dec 9, 2024 · a920056 · a920056
1 parent 6aad3bb
commit a920056
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 6 deletions.
diff --git a/packages/sanity/src/core/store/events/getDocumentAtRevision.ts b/packages/sanity/src/core/store/events/getDocumentAtRevision.ts
@@ -13,11 +13,8 @@ export function getDocumentAtRevision({
 }: {
   client: SanityClient
   documentId: string
-  revisionId: string | null | undefined
+  revisionId: string
 }): Observable<EventsStoreRevision | null> {
-  if (!revisionId) {
-    return of(null)
-  }
   const cacheKey = `${documentId}@${revisionId}`
   const dataset = client.config().dataset
   if (documentRevisionCache[cacheKey]) {

diff --git a/packages/sanity/src/core/store/events/useEventsStore.ts b/packages/sanity/src/core/store/events/useEventsStore.ts
@@ -96,7 +96,8 @@ export function useEventsStore({
   }, [events, rev])
 
   const revision$ = useMemo(
-    () => getDocumentAtRevision({client, documentId, revisionId: revisionId}),
+    () =>
+      revisionId ? getDocumentAtRevision({client, documentId, revisionId: revisionId}) : of(null),
     [client, documentId, revisionId],
   )
   const revision = useObservable(revision$, null)
@@ -122,7 +123,7 @@ export function useEventsStore({
   }, [events, revisionId, since])
 
   const since$ = useMemo(
-    () => getDocumentAtRevision({client, documentId, revisionId: sinceId}),
+    () => (sinceId ? getDocumentAtRevision({client, documentId, revisionId: sinceId}) : of(null)),
     [sinceId, client, documentId],
   )