doc(sanity): add TS-doc for block content related types #4674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
skogsmaskin
changed the title
skogsmaskin
force-pushed
the
feat/pt-tsdoc
branch
from
e8ebd59 to
1ef9af1
Compare
|
Is this ready for review, @skogsmaskin or does it still need work? |
I have some stuff locally that I will commit tomorrow that makes this PR ready for review. |
skogsmaskin
force-pushed
the
feat/pt-tsdoc
branch
from
a72fc63 to
0529ac2
Compare
|
Component Testing Report Updated Oct 9, 2023 11:16 AM (UTC)
|
skogsmaskin
force-pushed
the
feat/pt-tsdoc
branch
from
0529ac2 to
24e35e8
Compare
skogsmaskin
changed the title
skogsmaskin
changed the title
Full Report@sanity/types
sanity
@sanity/diff
@sanity/block-tools
sanity/desk
@sanity/portable-text-editor
@sanity/mutator
@sanity/cli
@sanity/schema/_internal
@sanity/util/paths
sanity/router
@sanity/util/legacyDateFormat
@sanity/schema
sanity/cli
@sanity/vision
@sanity/util/fs
sanity/_internal
@sanity/util/content
|
bjoerge
force-pushed
the
next
branch
2 times, most recently
from
e7bf4c3 to
4151f2e
Compare
Remove this non-working workshop left over from v2
bjoerge
approved these changes
Oct 9, 2023
There was a problem hiding this comment.
This looks great. Thank you for taking the time to do this, @skogsmaskin <3
skogsmaskin
added a commit
that referenced
this pull request
Oct 17, 2023
rexxars
pushed a commit
that referenced
this pull request
Oct 17, 2023
* chore(core/form/inputs): remove outdated workshop case Remove this non-working workshop left over from v2 * refactor(core/form/inputs): deprecate block marker callbacks and support * doc(types): add ts doc comments to block schema types * doc(sanity): add TS-doc for block content related types
binoy14
pushed a commit
that referenced
this pull request
Oct 18, 2023
* chore(core/form/inputs): remove outdated workshop case Remove this non-working workshop left over from v2 * refactor(core/form/inputs): deprecate block marker callbacks and support * doc(types): add ts doc comments to block schema types * doc(sanity): add TS-doc for block content related types
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 20, 2023
#5002) * doc(sanity): add TS-doc for block content related types (#4674) * chore(core/form/inputs): remove outdated workshop case Remove this non-working workshop left over from v2 * refactor(core/form/inputs): deprecate block marker callbacks and support * doc(types): add ts doc comments to block schema types * doc(sanity): add TS-doc for block content related types * fix(login): fix issue where logo is not shown on custom auth providers --------- Co-authored-by: Per-Kristian Nordnes <[email protected]>
rexxars
pushed a commit
that referenced
this pull request
Oct 20, 2023
* chore(core/form/inputs): remove outdated workshop case Remove this non-working workshop left over from v2 * refactor(core/form/inputs): deprecate block marker callbacks and support * doc(types): add ts doc comments to block schema types * doc(sanity): add TS-doc for block content related types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This will add ts-doc to the most used block-content related types in the
sanitypackage.What to review
@publichere is actually made public and documented elsewhere.Notes for release
N/A