fix(core): re-use previously prepared workspace configs #4867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
rexxars
approved these changes
Aug 25, 2023
bjoerge
force-pushed
the
stable-workspaces
branch
from
5edd45c to
7677c1e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, when using
<Studio config={[workspaceOptions1, workspaceOptions2]}>each workspace will still be setup/prepared at each render, even if they're unchanged, causing the studio to reload. This PR fixes this by keeping a weakmap between each given workspace options and the prepared workspace summary, and using the previously prepared one where there's no change between renders.What to review
Notes for release