-
Notifications
You must be signed in to change notification settings - Fork 440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: make splitpanes responsive for minimal breakpoint #4893
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
Component Testing Report Updated Sep 6, 2023 1:35 PM (UTC)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice - thanks @kmelve!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, LGTM!
0d92f82
to
e860660
Compare
Description
This PR makes the Vision plugin somewhat more responsive for narrow(er) screens by:
This is useful when you want to test a query on mobile or with a narrow studio in a browser‘s split pane. The balance between the query/param/results panes could probably be tuned a tiny bit more, but it's at least functional.
What to review
I did try to see if there was a way to reuse the Sanity UI logic to get the breakpoints but ended up doing a simple
window.innerWidth < 600
wrapped in thenarrowBreakpoint()
function.Notes for release
Responsive improvements to the Vision plugin to accommodate narrower screens.