Inline text filtering of mentions menu #4936

skogsmaskin · 2023-09-15T11:08:48Z

Description

This will build the mentions filter inside the actual text node of the editor.

Start with typing @ to activate the mentions menu, then type into the editor to do user filtering.

What to review

That the activation and deactivation of the mentions menu is working the way we want it to.
That it looks good (popover placement etc.)
Is adding the imperative handles the way to go to connect the MentionsMenu and context? Could the filtering be done directly into the provider? Especially, do we really need the added handle in CommandList?
That the changes for the Portable Text Editor module okay to do in this PR, or should be separated into their own PRs and reviewed as a separate concern?

vercel · 2023-09-15T11:08:56Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
performance-studio	✅ Ready (Inspect)	Visit Preview		Sep 27, 2023 3:42pm
test-studio	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Sep 27, 2023 3:42pm

1 Ignored Deployment

Name	Status	Preview	Comments	Updated (UTC)
studio-workshop	⬜️ Ignored (Inspect)	Visit Preview		Sep 27, 2023 3:42pm

github-actions · 2023-09-26T13:08:27Z

Package	Documentation Change
sanity	+1%

Full Report

sanity

This branch	Next branch
111 documented	110 documented
855 not documented	834 not documented

@sanity/diff

This branch	Next branch
13 documented	13 documented
16 not documented	16 not documented

@sanity/block-tools

This branch	Next branch
4 documented	4 documented
9 not documented	9 not documented

@sanity/types

This branch	Next branch
46 documented	46 documented
240 not documented	240 not documented

sanity/desk

This branch	Next branch
83 documented	83 documented
54 not documented	54 not documented

@sanity/portable-text-editor

This branch	Next branch
21 documented	21 documented
44 not documented	44 not documented

@sanity/mutator

This branch	Next branch
7 documented	7 documented
4 not documented	4 not documented

@sanity/cli

This branch	Next branch
1 documented	1 documented
30 not documented	30 not documented

@sanity/schema/_internal

This branch	Next branch
0 documented	0 documented
9 not documented	9 not documented

@sanity/util/paths

This branch	Next branch
1 documented	1 documented
15 not documented	15 not documented

sanity/router

This branch	Next branch
15 documented	15 documented
21 not documented	21 not documented

@sanity/util/legacyDateFormat

This branch	Next branch
0 documented	0 documented
3 not documented	3 not documented

@sanity/schema

This branch	Next branch
0 documented	0 documented
2 not documented	2 not documented

sanity/cli

This branch	Next branch
2 documented	2 documented
0 not documented	0 not documented

@sanity/vision

This branch	Next branch
0 documented	0 documented
2 not documented	2 not documented

@sanity/util/fs

This branch	Next branch
0 documented	0 documented
3 not documented	3 not documented

sanity/_internal

This branch	Next branch
0 documented	0 documented
1 not documented	1 not documented

@sanity/util/content

This branch	Next branch
1 documented	1 documented
5 not documented	5 not documented

github-actions · 2023-09-26T13:10:46Z

Component Testing Report Updated Sep 27, 2023 3:46 PM (UTC)

File	Status	Duration	Passed
formBuilder/ArrayInput.spec.tsx	✅ Passed (Inspect)	10s	3
formBuilder/inputs/PortableText/Annotations.spec.tsx	✅ Passed (Inspect)	12s	3
formBuilder/inputs/PortableText/Decorators.spec.tsx	✅ Passed (Inspect)	13s	6
formBuilder/inputs/PortableText/Input.spec.tsx	✅ Passed (Inspect)	17s	9
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx	✅ Passed (Inspect)	58s	18
formBuilder/inputs/PortableText/Styles.spec.tsx	✅ Passed (Inspect)	13s	6
formBuilder/inputs/PortableText/Toolbar.spec.tsx	✅ Passed (Inspect)	8s	3

packages/sanity/src/core/comments/components/pte/comment-input/CommentInputProvider.tsx

packages/sanity/src/core/comments/components/mentions/MentionsMenu.tsx

hermanwikner

Thank you, this is great 💯 I left a few minor comments, but otherwise I think this is good to go!

sjelfull · 2023-09-27T11:48:22Z

packages/sanity/src/core/comments/components/pte/comment-input/Editable.tsx

@@ -22,7 +24,7 @@ const EditableWrapStack = styled(Stack)(() => {
 export const StyledPopover = styled(Popover)(() => {
  return css`
    // Position the Popover relative to the @
-    transform: translateX(6px); // todo: improve
+    transform: translate(6px, 6px); // todo: improve


Ideally we would configure this through a prop on the Popover component (offset), but @sanity/ui doesn't support this yet.

I'll look into this as a separate thing once this is merged

sjelfull

LGTM. Left a small comment about how we handle the popover offset. It's fine for now as long as we don't support it in @sanity/ui.

skogsmaskin · 2023-09-27T13:00:05Z

I forced pushed a changed that gets rid of the selectCurrent imperative handle for the MentionsMenu. Works out of the box.

This is no longer in use it seems like. Removing for simplicity.

Make a explicit function to focus the editor at the end of the edited comment content as focusEditor fn is now used internally in the context provider. Also simplify an effect that focuses the component this way.

vercel bot deployed to Preview – performance-studio September 15, 2023 11:11 View deployment

vercel bot deployed to Preview – test-studio September 15, 2023 11:13 View deployment

skogsmaskin force-pushed the feat/comments-mvi-1-fix-mentions-menu branch from 347b3e2 to 519d6ad Compare September 15, 2023 11:51

vercel bot deployed to Preview – performance-studio September 15, 2023 11:53 View deployment

vercel bot deployed to Preview – test-studio September 15, 2023 11:54 View deployment

skogsmaskin force-pushed the feat/comments-mvi-1-fix-mentions-menu branch from 519d6ad to f7f6b64 Compare September 15, 2023 11:54

vercel bot deployed to Preview – performance-studio September 15, 2023 11:57 View deployment

vercel bot deployed to Preview – test-studio September 15, 2023 11:57 View deployment

skogsmaskin force-pushed the feat/comments-mvi-1-fix-mentions-menu branch from f7f6b64 to a766a38 Compare September 15, 2023 15:38

vercel bot deployed to Preview – performance-studio September 15, 2023 15:40 View deployment

vercel bot deployed to Preview – test-studio September 15, 2023 15:41 View deployment

skogsmaskin force-pushed the feat/comments-mvi-1-fix-mentions-menu branch from a766a38 to 712f56d Compare September 18, 2023 12:50

vercel bot deployed to Preview – performance-studio September 18, 2023 12:52 View deployment

vercel bot deployed to Preview – test-studio September 18, 2023 12:54 View deployment

vercel bot deployed to Preview – performance-studio September 18, 2023 14:24 View deployment

vercel bot deployed to Preview – test-studio September 18, 2023 14:26 View deployment

skogsmaskin force-pushed the feat/comments-mvi-1-fix-mentions-menu branch 2 times, most recently from 712f56d to 7317290 Compare September 19, 2023 08:15

vercel bot deployed to Preview – performance-studio September 19, 2023 08:17 View deployment

vercel bot deployed to Preview – test-studio September 19, 2023 08:18 View deployment

hermanwikner force-pushed the feat/comments-mvi-1 branch from a22642b to 614f402 Compare September 25, 2023 13:55

skogsmaskin force-pushed the feat/comments-mvi-1-fix-mentions-menu branch from 7317290 to 0873340 Compare September 26, 2023 13:05

skogsmaskin marked this pull request as ready for review September 26, 2023 13:06

skogsmaskin requested a review from hermanwikner September 26, 2023 13:06

skogsmaskin changed the title ~~Feat/comments mvi 1 fix mentions menu~~ Inline text filtering of mentions menu Sep 26, 2023

skogsmaskin requested review from sjelfull and robinpyon September 26, 2023 13:10

hermanwikner reviewed Sep 27, 2023

View reviewed changes

packages/sanity/src/core/comments/components/pte/comment-input/CommentInputProvider.tsx Show resolved Hide resolved

hermanwikner reviewed Sep 27, 2023

View reviewed changes

packages/sanity/src/core/comments/components/mentions/MentionsMenu.tsx Outdated Show resolved Hide resolved

hermanwikner approved these changes Sep 27, 2023

View reviewed changes

sjelfull reviewed Sep 27, 2023

View reviewed changes

sjelfull approved these changes Sep 27, 2023

View reviewed changes

skogsmaskin force-pushed the feat/comments-mvi-1-fix-mentions-menu branch from cfe6c41 to 84b5cc2 Compare September 27, 2023 12:58

vercel bot deployed to Preview – performance-studio September 27, 2023 13:01 View deployment

vercel bot deployed to Preview – test-studio September 27, 2023 13:01 View deployment

skogsmaskin force-pushed the feat/comments-mvi-1-fix-mentions-menu branch from 84b5cc2 to 540486e Compare September 27, 2023 13:01

vercel bot deployed to Preview – performance-studio September 27, 2023 13:04 View deployment

skogsmaskin force-pushed the feat/comments-mvi-1-fix-mentions-menu branch from 540486e to baa4438 Compare September 27, 2023 13:04

vercel bot deployed to Preview – performance-studio September 27, 2023 13:06 View deployment

vercel bot deployed to Preview – test-studio September 27, 2023 13:08 View deployment

skogsmaskin force-pushed the feat/comments-mvi-1-fix-mentions-menu branch from baa4438 to 796e9ac Compare September 27, 2023 13:13

vercel bot deployed to Preview – performance-studio September 27, 2023 13:15 View deployment

vercel bot deployed to Preview – test-studio September 27, 2023 13:16 View deployment

skogsmaskin added 2 commits September 27, 2023 15:41

refactor(comments): inline text filtering for mentions menu

9478e0b

refactor(comments): remove unused 'expanded' context

3532db9

This is no longer in use it seems like. Removing for simplicity.

skogsmaskin force-pushed the feat/comments-mvi-1-fix-mentions-menu branch from 796e9ac to c01b264 Compare September 27, 2023 14:19

vercel bot deployed to Preview – performance-studio September 27, 2023 14:22 View deployment

vercel bot deployed to Preview – test-studio September 27, 2023 14:23 View deployment

refactor(comments): introduce focus to end of content as explicit fn

e543e5a

Make a explicit function to focus the editor at the end of the edited comment content as focusEditor fn is now used internally in the context provider. Also simplify an effect that focuses the component this way.

skogsmaskin force-pushed the feat/comments-mvi-1-fix-mentions-menu branch from c01b264 to e543e5a Compare September 27, 2023 15:38

vercel bot deployed to Preview – performance-studio September 27, 2023 15:40 View deployment

vercel bot deployed to Preview – test-studio September 27, 2023 15:42 View deployment

skogsmaskin merged commit ec15b9c into feat/comments-mvi-1 Sep 27, 2023
12 of 14 checks passed

skogsmaskin deleted the feat/comments-mvi-1-fix-mentions-menu branch September 27, 2023 15:44

skogsmaskin removed request for robinpyon and kaylasanity September 27, 2023 15:55

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Inline text filtering of mentions menu #4936

Inline text filtering of mentions menu #4936

skogsmaskin commented Sep 15, 2023 •

edited

Loading

vercel bot commented Sep 15, 2023 •

edited

Loading

github-actions bot commented Sep 26, 2023

github-actions bot commented Sep 26, 2023 •

edited

Loading

hermanwikner left a comment

sjelfull Sep 27, 2023

hermanwikner Sep 27, 2023

sjelfull left a comment

skogsmaskin commented Sep 27, 2023

Inline text filtering of mentions menu #4936

Inline text filtering of mentions menu #4936

Conversation

skogsmaskin commented Sep 15, 2023 • edited Loading

Description

What to review

vercel bot commented Sep 15, 2023 • edited Loading

github-actions bot commented Sep 26, 2023

github-actions bot commented Sep 26, 2023 • edited Loading

hermanwikner left a comment

Choose a reason for hiding this comment

sjelfull Sep 27, 2023

Choose a reason for hiding this comment

hermanwikner Sep 27, 2023

Choose a reason for hiding this comment

sjelfull left a comment

Choose a reason for hiding this comment

skogsmaskin commented Sep 27, 2023

skogsmaskin commented Sep 15, 2023 •

edited

Loading

vercel bot commented Sep 15, 2023 •

edited

Loading

github-actions bot commented Sep 26, 2023 •

edited

Loading