fix(core): make sure to re-emit current edit state when re-subscribing to document validation #4954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
bjoerge
commented
Sep 27, 2023
| @@ -105,7 +106,7 @@ export const validation = memoize( | |||
| // so only pass on documents if _other_ attributes changes | |||
| return shallowEquals(omit(prev, '_rev', '_updatedAt'), omit(next, '_rev', '_updatedAt')) | |||
| }), | |||
| share(), | |||
| shareLatestWithRefCount(), | |||
There was a problem hiding this comment.
This is the line that fixes the issue. Since we were using share, re-subscribing to this observable didn't publish the current edit state of the document, leaving the validation in a pending state
|
No changes to documentation |
|
Component Testing Report Updated Sep 29, 2023 12:16 PM (UTC)
|
…g to document validation
binoy14
approved these changes
Oct 2, 2023
ricokahler
approved these changes
Oct 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes an issue that currently happens when editing a document that has a reference to an unpublished document, switching to another document and then switching back. Sometimes this could lead to the validation error for unpublished document reference being ignored.
Steps to reproduce:
Standard Inputs>Reference Test>REPRO SDX-736 #1" and observe that the reference field has the correct validation errorREPRO SDX-736 #2REPRO SDX-736 #1" and notice that the validation error has disappeared.What to review
Go to the branch deployment (https://test-studio-git-sdx-736.sanity.build/test/content) and make sure the above steps does not cause the validation error to disappear
I also took the opportunity to fixe a couple of deprecation warnings while at it.
Notes for release