fix(block-tools): fix Google Docs preprocessing issue on Windows #4955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On windows the Google Docs root-B was not stripped like it should be. Slightly different document structure. Use a more explicit xpath to get the Google Docs root node. Also prefer textContent over innerText when extracting span text. I was not able to have the tests running properly without this.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
|
No changes to documentation |
|
Component Testing Report Updated Sep 27, 2023 11:29 AM (UTC)
|
bjoerge
force-pushed
the
next
branch
2 times, most recently
from
e7bf4c3 to
4151f2e
Compare
robinpyon
approved these changes
Oct 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This will fix an issue on Windows when serializing a Google Docs HTML fragment into blocks.
The clipboard HTML was slightly different on Windows and our code didn't take that into account.
I have made some xpath matchers more specific and resilient now so they work both places.
I have also added tests for this.
What to review
That pasting from Google Docs into the PTE on Windows and MacOS will work correctly, without adding everything as bold.
Notes for release