Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): accessibility improvements on document lists #4958

Merged
merged 1 commit into from
Oct 2, 2023
Merged

Conversation

ninaandal
Copy link
Contributor

@ninaandal ninaandal commented Sep 29, 2023

Description

Items in document lists were marked up as div elements, but semantically, they are lists. The list items are now li, while the wrapper is a ul.

What to review

Make sure that document lists work as intended and that semantically, they are correct.

Notes for release

Improves accessibility for document lists

@vercel
Copy link

vercel bot commented Sep 29, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
performance-studio ✅ Ready (Inspect) Visit Preview Sep 29, 2023 9:54am
test-studio ✅ Ready (Inspect) Visit Preview Sep 29, 2023 9:54am
1 Ignored Deployment
Name Status Preview Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Sep 29, 2023 9:54am

@ninaandal ninaandal requested a review from a team September 29, 2023 09:54
@github-actions
Copy link
Contributor

No changes to documentation

@github-actions
Copy link
Contributor

Component Testing Report Updated Sep 29, 2023 10:00 AM (UTC)

File Status Duration Passed Skipped Failed
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 7s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 10s 3 0 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 9s 6 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 13s 9 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 47s 18 0 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 11s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 6s 3 0 0

Copy link
Member

@bjoerge bjoerge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ninaandal!

@bjoerge bjoerge merged commit 0fa5e70 into next Oct 2, 2023
14 checks passed
@bjoerge bjoerge deleted the edx-418 branch October 2, 2023 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants