test(e2e): prep work for making e2e more isolated #4961
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You must have Developer access to commit code to Sanity on Vercel. If you contact an administrator and receive Developer access, commit again to see your changes. Learn more: https://vercel.com/docs/concepts/teams/roles-and-permissions#enterprise-team-account-roles |
|
No changes to documentation |
|
Component Testing Report Updated Oct 13, 2023 4:35 PM (UTC)
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
bjoerge
force-pushed
the
next
branch
2 times, most recently
from
e7bf4c3 to
4151f2e
Compare
bjoerge
changed the title
binoy14
approved these changes
Oct 13, 2023
rexxars
pushed a commit
that referenced
this pull request
Oct 13, 2023
rexxars
pushed a commit
that referenced
this pull request
Oct 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updating our e2e test bench to not explicitly use the
testSanityClientbut rather the client to use be passed into the test. This will set us up for better test isolation going forward.What to review
The overall approach. The next step would be to do something similar with creating documents.
Notes for release
This is a test bench refactor and is not relevant in the release notes