fix(core): set default placements for certain studio popovers #4963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
The new default fallback placements for popovers released in Sanity UI v1.8.2 are good for most use cases, but in the studio it has been causing issues for the reference input, cross dataset referenc and document types button popover. This PR fixes these issues by explicitly choosing better fallback placements.
|
No changes to documentation |
|
Component Testing Report Updated Oct 2, 2023 12:41 PM (UTC)
|
This was referenced Oct 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The new default fallback placements for popovers released in Sanity UI v1.8.2 are good for most use cases, but in the Studio it has been causing issues for popovers used by the reference input, cross dataset reference input and the document type selector used by the array input.
This PR fixes these issues by explicitly choosing better fallback placements.
Before
What to review
Make popovers used by the following components places themselves where they should and renders nicely:
Notes for release