Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(i18n): convert date/datetime input strings to use i18n primitives #4973

Merged
merged 2 commits into from
Oct 6, 2023

Conversation

bjoerge
Copy link
Member

@bjoerge bjoerge commented Oct 4, 2023

Description

Adds internationalization capabilities to Date and DateTime inputs. Tried to keep as much as the i18n framework itself apart from the base datetime-picker, so limited the use of useTranslation() to the form input components.

@bjoerge bjoerge requested a review from rexxars October 4, 2023 13:12
@vercel
Copy link

vercel bot commented Oct 4, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
performance-studio ✅ Ready (Inspect) Visit Preview Oct 5, 2023 0:49am
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 5, 2023 0:49am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Visit Preview Oct 5, 2023 0:49am

@github-actions
Copy link
Contributor

github-actions bot commented Oct 4, 2023

Package Documentation Change
sanity +14%
@sanity/types +3%
sanity/desk +2%
Full Report
sanity
This branch Next branch
125 documented 110 documented
847 not documented 834 not documented
@sanity/types
This branch Next branch
47 documented 46 documented
240 not documented 240 not documented
sanity/desk
This branch Next branch
84 documented 83 documented
55 not documented 54 not documented
@sanity/diff
This branch Next branch
13 documented 13 documented
16 not documented 16 not documented
@sanity/block-tools
This branch Next branch
4 documented 4 documented
9 not documented 9 not documented
@sanity/portable-text-editor
This branch Next branch
21 documented 21 documented
44 not documented 44 not documented
@sanity/mutator
This branch Next branch
7 documented 7 documented
4 not documented 4 not documented
@sanity/cli
This branch Next branch
1 documented 1 documented
30 not documented 30 not documented
@sanity/schema/_internal
This branch Next branch
0 documented 0 documented
9 not documented 9 not documented
@sanity/util/paths
This branch Next branch
1 documented 1 documented
15 not documented 15 not documented
sanity/router
This branch Next branch
15 documented 15 documented
21 not documented 21 not documented
@sanity/util/legacyDateFormat
This branch Next branch
0 documented 0 documented
3 not documented 3 not documented
@sanity/schema
This branch Next branch
0 documented 0 documented
2 not documented 2 not documented
sanity/cli
This branch Next branch
2 documented 2 documented
0 not documented 0 not documented
@sanity/vision
This branch Next branch
0 documented 0 documented
2 not documented 2 not documented
@sanity/util/fs
This branch Next branch
0 documented 0 documented
3 not documented 3 not documented
sanity/_internal
This branch Next branch
0 documented 0 documented
1 not documented 1 not documented
@sanity/util/content
This branch Next branch
1 documented 1 documented
5 not documented 5 not documented

@github-actions
Copy link
Contributor

github-actions bot commented Oct 4, 2023

Component Testing Report Updated Oct 5, 2023 12:53 PM (UTC)

File Status Duration Passed Skipped Failed
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 10s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 11s 3 0 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 12s 6 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 15s 9 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 53s 18 0 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 12s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 7s 3 0 0

@bjoerge bjoerge changed the title feat(i18n): convert date/datetime input strings to use 18n primitives feat(i18n): convert date/datetime input strings to use i18n primitives Oct 4, 2023
Copy link
Member

@rexxars rexxars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Left a few suggestions. At some point we may have to/want to create a date input that accounts for different calendars, but that's for a different day.

CommonDateTimeInput has a test failure, should fix that before merging.

@bjoerge
Copy link
Member Author

bjoerge commented Oct 5, 2023

Addressed your fedback in 4a91c8b, thanks for reviewing :)

@bjoerge bjoerge merged commit b52a250 into feat/i18n Oct 6, 2023
14 checks passed
@bjoerge bjoerge deleted the sdx-618 branch October 6, 2023 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants