-
Notifications
You must be signed in to change notification settings - Fork 435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(i18n): convert date/datetime input strings to use i18n primitives #4973
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
Full Reportsanity
@sanity/types
sanity/desk
@sanity/diff
@sanity/block-tools
@sanity/portable-text-editor
@sanity/mutator
@sanity/cli
@sanity/schema/_internal
@sanity/util/paths
sanity/router
@sanity/util/legacyDateFormat
@sanity/schema
sanity/cli
@sanity/vision
@sanity/util/fs
sanity/_internal
@sanity/util/content
|
Component Testing Report Updated Oct 5, 2023 12:53 PM (UTC)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Left a few suggestions. At some point we may have to/want to create a date input that accounts for different calendars, but that's for a different day.
CommonDateTimeInput
has a test failure, should fix that before merging.
packages/sanity/src/core/form/inputs/DateInputs/base/calendar/CalendarMonth.tsx
Show resolved
Hide resolved
packages/sanity/src/core/form/inputs/DateInputs/base/calendar/types.ts
Outdated
Show resolved
Hide resolved
packages/sanity/src/core/form/inputs/DateInputs/base/calendar/Calendar.tsx
Outdated
Show resolved
Hide resolved
packages/sanity/src/core/form/inputs/DateInputs/base/calendar/types.ts
Outdated
Show resolved
Hide resolved
Addressed your fedback in 4a91c8b, thanks for reviewing :) |
Description
Adds internationalization capabilities to Date and DateTime inputs. Tried to keep as much as the i18n framework itself apart from the base datetime-picker, so limited the use of
useTranslation()
to the form input components.