feat(cli): add CDR metadata to GraphQL json schema #4975
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
|
No changes to documentation |
|
Component Testing Report Updated Oct 4, 2023 11:01 PM (UTC)
|
binoy14
reviewed
Oct 5, 2023
bjoerge
force-pushed
the
next
branch
2 times, most recently
from
e7bf4c3 to
4151f2e
Compare
binoy14
approved these changes
Oct 16, 2023
rexxars
approved these changes
Oct 17, 2023
rexxars
pushed a commit
that referenced
this pull request
Oct 17, 2023
rexxars
pushed a commit
that referenced
this pull request
Oct 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The following PR adds CDR metadata to the GraphQL json schema to enable CDR support in the
gatsby-source-sanityplugin.There's a new key under the
ConvertedTypeinterface labeledcrossDatasetReferenceMetadatathat includes the dataset name and the type names.Important note: Our graphql service must be updated before this gets merged else all GraphQL deployments with crossDatasetReferences will fail because of the extra key.
Fixes SDX-768
Fixes SDX-765
What to review
See the updated types and tests to see how the GraphQL JSON schema will change.
Notes for release
N/A (more of an internal add for the time being)