-
Notifications
You must be signed in to change notification settings - Fork 435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(i18n): convert file, image and imagetool input strings to use i18n primitives #4984
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
Full Reportsanity
@sanity/types
sanity/desk
@sanity/diff
@sanity/block-tools
@sanity/portable-text-editor
@sanity/mutator
@sanity/cli
@sanity/schema/_internal
@sanity/util/paths
sanity/router
@sanity/util/legacyDateFormat
@sanity/schema
sanity/cli
@sanity/vision
@sanity/util/fs
sanity/_internal
@sanity/util/content
|
Component Testing Report Updated Oct 12, 2023 8:07 PM (UTC)
|
rexxars
requested changes
Oct 10, 2023
packages/sanity/src/core/form/inputs/files/common/PlaceholderText.tsx
Outdated
Show resolved
Hide resolved
packages/sanity/src/core/form/inputs/files/common/PlaceholderText.tsx
Outdated
Show resolved
Hide resolved
packages/sanity/src/core/form/inputs/files/common/UploadProgress.tsx
Outdated
Show resolved
Hide resolved
… use i18n primitives
Feedback addressed in 634c214. Thanks! |
rexxars
approved these changes
Oct 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! LGTM.
rexxars
pushed a commit
that referenced
this pull request
Oct 20, 2023
bjoerge
added a commit
that referenced
this pull request
Oct 23, 2023
bjoerge
added a commit
that referenced
this pull request
Nov 6, 2023
bjoerge
added a commit
that referenced
this pull request
Nov 6, 2023
bjoerge
added a commit
that referenced
this pull request
Nov 6, 2023
rexxars
pushed a commit
that referenced
this pull request
Nov 17, 2023
rexxars
pushed a commit
that referenced
this pull request
Nov 20, 2023
rexxars
pushed a commit
that referenced
this pull request
Nov 22, 2023
bjoerge
added a commit
that referenced
this pull request
Nov 27, 2023
bjoerge
added a commit
that referenced
this pull request
Nov 28, 2023
rexxars
pushed a commit
that referenced
this pull request
Nov 28, 2023
rexxars
pushed a commit
that referenced
this pull request
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds internationalization capabilities to Image and File inputs and common supporting components.
Notes for review