feat(i18n): use Intl APIs for TimeAgo component
#4990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
Full Reportsanity
sanity/desk
@sanity/diff
@sanity/block-tools
@sanity/portable-text-editor
@sanity/mutator
@sanity/cli
@sanity/schema/_internal
@sanity/util/paths
sanity/router
@sanity/util/legacyDateFormat
@sanity/schema
sanity/cli
@sanity/vision
@sanity/util/fs
sanity/_internal
@sanity/util/content
@sanity/types
|
|
Component Testing Report Updated Oct 16, 2023 9:22 PM (UTC)
|
bjoerge
approved these changes
Oct 16, 2023
| @@ -51,22 +51,22 @@ describe('useTimeAgo', () => { | |||
| expect(result.current).toBe('Jun 3, 2022') | |||
| }) | |||
|
|
|||
| it('outputs eg "3w" if less than a month apart', () => { | |||
| it('outputs eg "3 wks" if less than a month apart', () => { | |||
There was a problem hiding this comment.
Does this replace the "3w" short format with the slightly longer "3 wks" all over? Since these are used in confined areas of the UI, will this risk running into issues with text no longer fitting the space it's given?
There was a problem hiding this comment.
It does! @mikolajdobrucki approved this from the design side, but we should still have a look around and see if anything breaks - but we can easily change this after merging if problematic.
binoy14
approved these changes
Oct 16, 2023
rexxars
force-pushed
the
feat/i18n-relative-time
branch
from
56d0638 to
cd7acf7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Note: review this commit by commit to more easily understand things.
intlCache. We will need to instantiate several different instances of the Intl APIs with differing options, and this is a semi-costly operation. The cache ensures we reuse instances where possible.useIntlListFormathook utilize said cache to prove it works (also, why not)useTimeAgohook to allow for both past and future dates (X days ago, in Y hours)useTimeAgohook use i18n primitivesuseTimeAgoand theTimeAgocomponent touseRelativeTimeandRelativeTime, respectively. This is done because it more closely aligns with theIntl.RelativeTimeFormatAPI, as well as indicating that it can now show dates in the future as well.Closes SDX-677