fix(i18n): camelCase to kebab-case for resource ids

[jtpetty]

Description

Fixes some resource ids that were changed from camelCase to kebab-case but usages were not changed accordingly.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
performance-studio	✅ Ready (Inspect)	Visit Preview		Oct 16, 2023 7:29pm
test-studio	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 16, 2023 7:29pm

1 Ignored Deployment

Name	Status	Preview	Comments	Updated (UTC)
studio-workshop	⬜️ Ignored (Inspect)	Visit Preview		Oct 16, 2023 7:29pm

[github-actions]

Package	Documentation Change
sanity	+7%
sanity/desk	+2%
@sanity/types	-11%

Full Report

sanity

This branch	Next branch
127 documented	119 documented
847 not documented	825 not documented

sanity/desk

This branch	Next branch
84 documented	83 documented
56 not documented	55 not documented

@sanity/diff

This branch	Next branch
13 documented	13 documented
16 not documented	16 not documented

@sanity/block-tools

This branch	Next branch
4 documented	4 documented
9 not documented	9 not documented

@sanity/portable-text-editor

This branch	Next branch
21 documented	21 documented
44 not documented	44 not documented

@sanity/mutator

This branch	Next branch
7 documented	7 documented
4 not documented	4 not documented

@sanity/cli

This branch	Next branch
1 documented	1 documented
30 not documented	30 not documented

@sanity/schema/_internal

This branch	Next branch
0 documented	0 documented
9 not documented	9 not documented

@sanity/util/paths

This branch	Next branch
1 documented	1 documented
15 not documented	15 not documented

sanity/router

This branch	Next branch
15 documented	15 documented
21 not documented	21 not documented

@sanity/util/legacyDateFormat

This branch	Next branch
0 documented	0 documented
3 not documented	3 not documented

@sanity/schema

This branch	Next branch
0 documented	0 documented
2 not documented	2 not documented

sanity/cli

This branch	Next branch
2 documented	2 documented
0 not documented	0 not documented

@sanity/vision

This branch	Next branch
0 documented	0 documented
2 not documented	2 not documented

@sanity/util/fs

This branch	Next branch
0 documented	0 documented
3 not documented	3 not documented

sanity/_internal

This branch	Next branch
0 documented	0 documented
1 not documented	1 not documented

@sanity/util/content

This branch	Next branch
1 documented	1 documented
5 not documented	5 not documented

@sanity/types

This branch	Next branch
47 documented	53 documented
240 not documented	233 not documented

[github-actions]

Component Testing Report Updated Oct 16, 2023 7:32 PM (UTC)

File	Status	Duration	Passed	Skipped	Failed
formBuilder/ArrayInput.spec.tsx	✅ Passed (Inspect)	6s	3	0	0
formBuilder/inputs/PortableText/Annotations.spec.tsx	✅ Passed (Inspect)	8s	3	0	0
formBuilder/inputs/PortableText/Decorators.spec.tsx	✅ Passed (Inspect)	10s	6	0	0
formBuilder/inputs/PortableText/Input.spec.tsx	✅ Passed (Inspect)	13s	9	0	0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx	✅ Passed (Inspect)	45s	18	0	0
formBuilder/inputs/PortableText/Styles.spec.tsx	✅ Passed (Inspect)	9s	6	0	0
formBuilder/inputs/PortableText/Toolbar.spec.tsx	✅ Passed (Inspect)	5s	3	0	0

[rexxars]

I spy a few more camelcased resource IDs (the locale bundle needs to be updated to match, and ideally also take a look at dev/test-studio/plugins/locale-no-nb/bundles/desk.ts and see if you can align those as well)

[jtpetty]

@rexxars - Thanks for finding the ones I missed. I think I got those now. I look at all the remaining calls to t() and I only see timeAgo as camel case. Are you fixing that in your PR?

[bjoerge]

Sorry for not catching those. I was under the impression that these would trigger a compile error if they didn't match valid resource ids, but see now that that only works if you define them as a record of resource keys at usage site. Would be nice if we could find an easy way of enforcing that. Not trying to dodge blame, but this almost feels like a too easy mistake to do 😅 (and something that should be possible to catch statically?)

[jtpetty]

Sorry for not catching those. I was under the impression that these would trigger a compile error if they didn't match valid resource ids, but see now that that only works if you define them as a record of resource keys at usage site. Would be nice if we could find an easy way of enforcing that. Not trying to dodge blame, but this almost feels like a too easy mistake to do 😅 (and something that should be possible to catch statically?)

I completely agree with you. There should be some way for this to trigger an error somewhere.