chore(e2e): create a test studio for e2e tests #5044
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
No changes to documentation |
|
Component Testing Report Updated Oct 26, 2023 4:56 PM (UTC)
|
skogsmaskin
pushed a commit
that referenced
this pull request
Nov 2, 2023
* chore(e2e): create a test studio for e2e tests * chore(e2e): use correct token * chore(e2e): add basePath to testing studio * chore(e2e): use test-studio as a dependency cleanup packages * chore(e2e): remove unused dependency * chore(e2e): run e2e tests in production build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR creates a new studio instance that is inheriting the schema from the test studio but works in isolation with the idea being this studio is solely used for e2e testing. This studio also takes the projectId and dataset as env variables with the idea being that we would create a new dataset per PR which is removed after the PR is merged (future PR for this) this makes sure that the tests are run in true isolation and not affected by any side effects during development or testing.
Other changes in this PR is that now the e2e tests in CI run on the production build of the studio which removes the CI flakyness out of the equation trying to serve a page. Since it would be the production build it should also match very closely to what is deployed.
What to review
Notes for release