-
Notifications
You must be signed in to change notification settings - Fork 435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(test): jest 29 migration #5069
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
No changes to documentation |
Component Testing Report Updated Oct 26, 2023 2:36 PM (UTC)
|
New, updated, and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: [email protected] |
👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎ This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. |
9459e77
to
f3cf9aa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it running all the tests on the CI now?
Found them :) |
* chore: migrate to jest 28 * chore: test jest sharding * chore(test): ignore playwright tests * chore(test): revert ci changes from base * chore(test): add sharding * chore(test): fix shard dataset name and remove unused deps * chore(test): split install and test jobs * chore(test): restore npm cache in test step * chore(test): add install step * chore(test): fix cache name * chore(test): install playwright in test steps * chore(test): move playwright install after install * chore(test): upgrade to jest 29 * chore(test): dedupe yarn.lock * chore(dev): remove the create react app starter example * chore(deps): add missing dev dependency * chore(portable-text-editor): speed up tests * chore(portable-text-editor): update jest-dev-server --------- Co-authored-by: Fred Carlsen <[email protected]> Co-authored-by: Bjørge Næss <[email protected]> Co-authored-by: Per-Kristian Nordnes <[email protected]>
Description
This PR upgrades jest to v29 and adds sharding to jest tests saving about 8 mins on the run. (We can tweak number of shards and see if it speeds up things more as needed but this is the first pass at it)
Thanks to @sjelfull for starting this branch I took most of his work and added to it!
Fixes SDX-800
What to review
Tests pass
Notes for release