-
Notifications
You must be signed in to change notification settings - Fork 435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(i18n): adds translation for desk panes #5085
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
Full Reportsanity
@sanity/types
sanity/desk
@sanity/diff
@sanity/block-tools
@sanity/portable-text-editor
@sanity/mutator
@sanity/cli
@sanity/schema/_internal
@sanity/util/paths
sanity/router
@sanity/util/legacyDateFormat
@sanity/schema
sanity/cli
@sanity/vision
@sanity/util/fs
sanity/_internal
@sanity/util/content
|
Component Testing Report Updated Nov 2, 2023 7:39 PM (UTC)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice - just a couple of questions/suggestions, no blockers
packages/sanity/src/desk/panes/document/DocumentOperationResults.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work!
We need to rework some keys, but would be open to doing it as part of a separate PR so marking this as approved - feel free to merge or address in this PR based on your preference
packages/sanity/src/desk/panes/document/DocumentOperationResults.tsx
Outdated
Show resolved
Hide resolved
packages/sanity/src/desk/panes/document/DocumentOperationResults.tsx
Outdated
Show resolved
Hide resolved
packages/sanity/src/desk/panes/document/documentPanel/header/DocumentHeaderTitle.tsx
Outdated
Show resolved
Hide resolved
} | ||
|
||
if (error) { | ||
return <>Error: {error.message}</> | ||
return <>{t('header.document-header-title.error.text', {error: error.message})}</> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wondering how to reason about these errors that will most likely be in english. Fine for now, but should we flag these somehow for later review?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we can add a todo
here. Maybe something like // @todo: i18n review second pass
?
Description
Adds translation for files in
packages/sanity/src/desk/panes/