refactor(core): desk renaming popover

[hermanwikner]

Description

This pull request updates the implementation that displays the popover informing about the renaming of desk to structure. Currently, this is handled by providing a custom icon component, which is wrapped with a popover. However, the icon will soon be removed from the tool menu buttons, and we will, therefore, need to update how this popover is rendered.

The solution that this pull request implements is to utilize the tool options property in deskTool to configure the popover component. Then, inside the tool menu component(s), we check if this popover is configured and render it.

Note that this solution is not very elegant and should be considered a temporary fix that will soon be removed. However, from exploring how to approach this, this seems to be the most reliable and stable solution for now.

What to review

• The popover should be rendered as before, however, the positioning might be slightly different, as the reference element is no longer the icon but the children of the button.
• Could this be solved differently?

Notes for release

N/A

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
performance-studio	✅ Ready (Inspect)	Visit Preview		Dec 14, 2023 0:23am
test-studio	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Dec 14, 2023 0:23am

1 Ignored Deployment

Name	Status	Preview	Comments	Updated (UTC)
studio-workshop	⬜️ Ignored (Inspect)	Visit Preview		Dec 14, 2023 0:23am

[github-actions]

Package	Documentation Change
sanity	-3%

Full Report

@sanity/diff

This branch	Next branch
13 documented	13 documented
16 not documented	16 not documented

@sanity/block-tools

This branch	Next branch
4 documented	4 documented
9 not documented	9 not documented

@sanity/types

This branch	Next branch
54 documented	54 documented
235 not documented	235 not documented

sanity/desk

This branch	Next branch
85 documented	85 documented
60 not documented	60 not documented

@sanity/portable-text-editor

This branch	Next branch
21 documented	21 documented
44 not documented	44 not documented

@sanity/mutator

This branch	Next branch
7 documented	7 documented
4 not documented	4 not documented

@sanity/cli

This branch	Next branch
1 documented	1 documented
30 not documented	30 not documented

@sanity/schema/_internal

This branch	Next branch
0 documented	0 documented
9 not documented	9 not documented

@sanity/util/paths

This branch	Next branch
1 documented	1 documented
15 not documented	15 not documented

sanity/router

This branch	Next branch
17 documented	17 documented
26 not documented	26 not documented

@sanity/util/legacyDateFormat

This branch	Next branch
0 documented	0 documented
3 not documented	3 not documented

@sanity/schema

This branch	Next branch
0 documented	0 documented
2 not documented	2 not documented

sanity/cli

This branch	Next branch
2 documented	2 documented
0 not documented	0 not documented

@sanity/vision

This branch	Next branch
0 documented	0 documented
3 not documented	3 not documented

@sanity/util/fs

This branch	Next branch
0 documented	0 documented
3 not documented	3 not documented

sanity/_internal

This branch	Next branch
0 documented	0 documented
1 not documented	1 not documented

@sanity/util/content

This branch	Next branch
1 documented	1 documented
5 not documented	5 not documented

sanity

This branch	Next branch
169 documented	176 documented
837 not documented	844 not documented

[github-actions]

Component Testing Report Updated Dec 14, 2023 12:24 PM (UTC)

File	Status	Duration	Passed	Skipped	Failed
comments/CommentInput.spec.tsx	✅ Passed (Inspect)	16s	15	0	0
formBuilder/ArrayInput.spec.tsx	✅ Passed (Inspect)	2s	3	0	0
formBuilder/inputs/PortableText/Annotations.spec.tsx	✅ Passed (Inspect)	9s	3	0	0
formBuilder/inputs/PortableText/Decorators.spec.tsx	✅ Passed (Inspect)	6s	6	0	0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx	✅ Passed (Inspect)	16s	15	0	0
formBuilder/inputs/PortableText/Input.spec.tsx	✅ Passed (Inspect)	8s	9	0	0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx	✅ Passed (Inspect)	38s	18	0	0
formBuilder/inputs/PortableText/Styles.spec.tsx	✅ Passed (Inspect)	6s	6	0	0
formBuilder/inputs/PortableText/Toolbar.spec.tsx	✅ Passed (Inspect)	3s	3	0	0

[pedrobonamin]

Thanks for this @hermanwikner !

[binoy14]

LGTM

[ninaandal]

Thank you Herman 🙌