Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): change telemetry event names #5832

Merged
merged 2 commits into from
Feb 27, 2024
Merged

fix(core): change telemetry event names #5832

merged 2 commits into from
Feb 27, 2024

Conversation

ninaandal
Copy link
Contributor

Description

What to review

Testing

Notes for release

@ninaandal ninaandal requested a review from a team as a code owner February 23, 2024 11:48
@vercel Vercel
Copy link

vercel bot commented Feb 23, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
performance-studio ✅ Ready (Inspect) Visit Preview Feb 26, 2024 8:49pm
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 26, 2024 8:49pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Visit Preview Feb 26, 2024 8:49pm

@github-actions GitHub Actions
Copy link
Contributor

No changes to documentation

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 23, 2024 •
edited
Loading

Component Testing Report Updated Feb 26, 2024 8:53 PM (UTC)

File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 33s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 6s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 12s 3 0 0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 12s 4 2 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 12s 6 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 33s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 1m 1s 15 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 1m 3s 18 0 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 13s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 19s 9 0 0

svirs
svirs reviewed Feb 23, 2024
View reviewed changes
packages/sanity/src/core/form/__telemetry__/form.telemetry.ts
@@ -14,7 +14,7 @@ export const PortableTextInputCollapsed = defineEvent({

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A comment about the structure of the names here could help in the future:
“<object/noun> <action/verb>”

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should maybe be documented in your documentation though? Since I assume this is global

@ninaandal ninaandal force-pushed the fix/telemetry-naming branch from 187e889 to c1d024b Compare February 26, 2024 20:45
@ninaandal ninaandal enabled auto-merge February 27, 2024 14:24
@ninaandal ninaandal requested a review from svirs February 27, 2024 15:40
@ninaandal ninaandal added this pull request to the merge queue Feb 27, 2024
Merged via the queue into next with commit 242e2ca Feb 27, 2024
40 checks passed
@ninaandal ninaandal deleted the fix/telemetry-naming branch February 27, 2024 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joneidejohnsen joneidejohnsen joneidejohnsen approved these changes

@svirs svirs svirs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ninaandal @svirs @joneidejohnsen