fix: wait for all streams to close when writing backups

[rneatherway]

Description

Without these changes I would often receive Error: Archiving backup failed: Size mismatch when using sanity backup download. I would also sometimes instead find that the tarball was successfully created but contained truncated files.

What to review

My use of streams - I do not have much experience with them. I am not sure if the changes to the docOutStream are necessary.

Testing

I tested this with a script that:

1. runs sanity backup download
2. if that succeeds, untars the export-format tarball and checks the sha1sum of all images against their filenames

I then ran this script in a loop. Before the change it rarely succeeded. After the change it has run for hundreds of iterations in a row without failing.

Notes for release

None needed, this feature is not yet formally released.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
performance-studio	✅ Ready (Inspect)	Visit Preview		Feb 26, 2024 3:17pm
test-studio	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Feb 26, 2024 3:17pm

1 Ignored Deployment

Name	Status	Preview	Comments	Updated (UTC)
studio-workshop	⬜️ Ignored (Inspect)	Visit Preview		Feb 26, 2024 3:17pm

[github-actions]

No changes to documentation

[github-actions]

Component Testing Report Updated Feb 26, 2024 3:22 PM (UTC)

File	Status	Duration	Passed	Skipped	Failed
comments/CommentInput.spec.tsx	✅ Passed (Inspect)	33s	15	0	0
formBuilder/ArrayInput.spec.tsx	✅ Passed (Inspect)	6s	3	0	0
formBuilder/inputs/PortableText/Annotations.spec.tsx	✅ Passed (Inspect)	13s	3	0	0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx	✅ Passed (Inspect)	12s	4	2	0
formBuilder/inputs/PortableText/Decorators.spec.tsx	✅ Passed (Inspect)	12s	6	0	0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx	✅ Passed (Inspect)	33s	15	0	0
formBuilder/inputs/PortableText/Input.spec.tsx	✅ Passed (Inspect)	1m 2s	15	0	0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx	✅ Passed (Inspect)	1m 3s	18	0	0
formBuilder/inputs/PortableText/Styles.spec.tsx	✅ Passed (Inspect)	13s	6	0	0
formBuilder/inputs/PortableText/Toolbar.spec.tsx	✅ Passed (Inspect)	20s	9	0	0

[j33ty]

Interesting, good find. Thank you for taking it up. I must say I am not much familiar with Node streams either and would love a re-review from Studio team.

[binoy14]

Not familiar with this pipeline API but given this feature is not formally release and there is a task to add tests for this happy to approve it since quick glance at the docs it does what is expected