chore: update eslint-config-i18n to ^1.1.0 #6210
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
|
No changes to documentation |
|
Component Testing Report Updated Apr 4, 2024 4:32 PM (UTC)
|
cngonzalez
force-pushed
the
chore/update-sanity-i18n-eslint
branch
from
bb365a0 to
480086e
Compare
cngonzalez
commented
Apr 4, 2024
| @@ -9,6 +9,7 @@ import { | |||
| } from '@sanity/ui' | |||
| import type * as React from 'react' | |||
| import {type ComponentProps, forwardRef} from 'react' | |||
| //eslint-disable-next-line @sanity/i18n/no-i18next-import -- avoiding a circular import | |||
| import {useTranslation} from 'react-i18next' | |||
There was a problem hiding this comment.
It seems problematic to import from sanity here, and traversing up and down the file tree to get to core also seems problematic at best.
cngonzalez
requested review from
sjelfull and
ricokahler
and removed request for
a team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I received a request to review a renovabot PR that upped the version of this lint rule to not allow imports from
i18next. Since we had those, it required a manual handling of those places where did previously import this.What to review
I've made the following changes:
structureto import fromsanityrather thani18next.Testing
Does it pass our linting rules?