Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(core): remove unusued ChangeIndicatorContext #6214

Merged
merged 1 commit into from
Apr 5, 2024

Conversation

binoy14
Copy link
Contributor

@binoy14 binoy14 commented Apr 4, 2024

Description

Looks like ChangeIndicatorContext is not used anywhere, it's @internal so it should be safe to remove

What to review

If I missed anything and it's actually being used

Testing

Notes for release

N/A

@binoy14 binoy14 requested a review from a team as a code owner April 4, 2024 20:17
@binoy14 binoy14 requested review from juice49 and removed request for a team April 4, 2024 20:17
Copy link

vercel bot commented Apr 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
performance-studio ✅ Ready (Inspect) Visit Preview Apr 4, 2024 8:20pm
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 4, 2024 8:20pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Apr 4, 2024 8:20pm

Copy link
Contributor

github-actions bot commented Apr 4, 2024

No changes to documentation

Copy link
Contributor

github-actions bot commented Apr 4, 2024

Component Testing Report Updated Apr 4, 2024 8:27 PM (UTC)

File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 37s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 6s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 25s 6 0 0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 12s 4 2 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 12s 6 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 32s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 59s 14 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 1m 1s 18 0 0
formBuilder/inputs/PortableText/RangeDecoration.spec.tsx ✅ Passed (Inspect) 11s 6 0 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 13s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 20s 9 0 0

Copy link
Contributor

@jtpetty jtpetty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also don't see it used anywhere. 👍

@binoy14 binoy14 added this pull request to the merge queue Apr 5, 2024
Merged via the queue into next with commit e978813 Apr 5, 2024
36 checks passed
@binoy14 binoy14 deleted the chore/remove-unused-ctx branch April 5, 2024 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants