fix(structure): prevent duplication of search filters when listenSearchQuery
is used (e.g. in document lists)
#6247
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Both the
createSearch
factory and the returnedsearch
function accept afilter
option. These filters are additive (joined together using the&&
operator). We were accidentally providing the same filter to both functions, causing it to be needlessly duplicated in the produced search request.What to review
Document list filtering and search works the same way as before, but the produced search request no longer contains duplicated filters.
Testing
We do not have tests for the
listenSearchQuery
function at the moment. Given this is a very limited change, I've not invested in adding a test suite at this point in time.