Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: move createWrapper to test package, update name -> slug #7177

Merged
merged 5 commits into from
Jul 19, 2024

Conversation

RitaDias
Copy link
Contributor

@RitaDias RitaDias commented Jul 17, 2024

Description

  • Update name -> slug on the temporary groq query (dummy getters)
  • Update issue with document badge & current global bundle not aligning based on the id
  • Move CreateWrapper to test package + updates to test imports
  • Move tests from structure to test (alongside other tests, simplifies imports)

@RitaDias RitaDias requested a review from a team as a code owner July 17, 2024 14:34
@RitaDias RitaDias requested review from juice49 and removed request for a team July 17, 2024 14:34
Copy link

vercel bot commented Jul 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
page-building-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 19, 2024 9:32am
performance-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 19, 2024 9:32am
test-compiled-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 19, 2024 9:32am
test-next-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 19, 2024 9:32am
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 19, 2024 9:32am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Visit Preview Jul 19, 2024 9:32am

Copy link
Contributor

No changes to documentation

@@ -26,7 +26,7 @@ export function DocumentPerspectiveMenu(props: {documentId: string}): JSX.Elemen
const {currentGlobalBundle} = usePerspective()
const bundles = useMemo(() => data ?? [], [data])

const existsInBundle = bundles.some((bundle) => bundle.slug === getBundleSlug(documentId))
const existsInBundle = getBundleSlug(documentId) === currentGlobalBundle?.slug
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was the misaligned logic here surfaced by the test by any chance? 👀
Least if it was you can say that all the toil was worth it...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have to admit I don't recall 🥲

Copy link
Member

@jordanl17 jordanl17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one @RitaDias.
Great to see just a single, wrapper being used. I'll try reuse this for a few tests I'm adding to the plugin

@RitaDias RitaDias merged commit 8872e64 into corel Jul 19, 2024
37 of 41 checks passed
@RitaDias RitaDias deleted the corel-quickfix branch July 19, 2024 10:01
bjoerge pushed a commit that referenced this pull request Jul 24, 2024
* fix: issue with slugs and condition

* fix: issue with badge with global bundle + tests

* chore: update test imports

* test: update createWrapper import

* refactor: update dummygetters to reflect corel
bjoerge pushed a commit that referenced this pull request Jul 24, 2024
* fix: issue with slugs and condition

* fix: issue with badge with global bundle + tests

* chore: update test imports

* test: update createWrapper import

* refactor: update dummygetters to reflect corel
bjoerge pushed a commit that referenced this pull request Jul 30, 2024
* fix: issue with slugs and condition

* fix: issue with badge with global bundle + tests

* chore: update test imports

* test: update createWrapper import

* refactor: update dummygetters to reflect corel
bjoerge pushed a commit that referenced this pull request Jul 30, 2024
* fix: issue with slugs and condition

* fix: issue with badge with global bundle + tests

* chore: update test imports

* test: update createWrapper import

* refactor: update dummygetters to reflect corel
bjoerge pushed a commit that referenced this pull request Aug 2, 2024
* fix: issue with slugs and condition

* fix: issue with badge with global bundle + tests

* chore: update test imports

* test: update createWrapper import

* refactor: update dummygetters to reflect corel
juice49 pushed a commit that referenced this pull request Aug 4, 2024
* fix: issue with slugs and condition

* fix: issue with badge with global bundle + tests

* chore: update test imports

* test: update createWrapper import

* refactor: update dummygetters to reflect corel
juice49 pushed a commit that referenced this pull request Aug 6, 2024
* fix: issue with slugs and condition

* fix: issue with badge with global bundle + tests

* chore: update test imports

* test: update createWrapper import

* refactor: update dummygetters to reflect corel
bjoerge pushed a commit that referenced this pull request Aug 7, 2024
* fix: issue with slugs and condition

* fix: issue with badge with global bundle + tests

* chore: update test imports

* test: update createWrapper import

* refactor: update dummygetters to reflect corel
bjoerge pushed a commit that referenced this pull request Aug 16, 2024
* fix: issue with slugs and condition

* fix: issue with badge with global bundle + tests

* chore: update test imports

* test: update createWrapper import

* refactor: update dummygetters to reflect corel
bjoerge pushed a commit that referenced this pull request Aug 20, 2024
* fix: issue with slugs and condition

* fix: issue with badge with global bundle + tests

* chore: update test imports

* test: update createWrapper import

* refactor: update dummygetters to reflect corel
bjoerge pushed a commit that referenced this pull request Aug 20, 2024
* fix: issue with slugs and condition

* fix: issue with badge with global bundle + tests

* chore: update test imports

* test: update createWrapper import

* refactor: update dummygetters to reflect corel
bjoerge pushed a commit that referenced this pull request Aug 20, 2024
* fix: issue with slugs and condition

* fix: issue with badge with global bundle + tests

* chore: update test imports

* test: update createWrapper import

* refactor: update dummygetters to reflect corel
RitaDias added a commit that referenced this pull request Aug 23, 2024
* fix: issue with slugs and condition

* fix: issue with badge with global bundle + tests

* chore: update test imports

* test: update createWrapper import

* refactor: update dummygetters to reflect corel
RitaDias added a commit that referenced this pull request Aug 26, 2024
* fix: issue with slugs and condition

* fix: issue with badge with global bundle + tests

* chore: update test imports

* test: update createWrapper import

* refactor: update dummygetters to reflect corel
juice49 pushed a commit that referenced this pull request Sep 3, 2024
* fix: issue with slugs and condition

* fix: issue with badge with global bundle + tests

* chore: update test imports

* test: update createWrapper import

* refactor: update dummygetters to reflect corel
RitaDias added a commit that referenced this pull request Oct 3, 2024
* fix: issue with slugs and condition

* fix: issue with badge with global bundle + tests

* chore: update test imports

* test: update createWrapper import

* refactor: update dummygetters to reflect corel
juice49 pushed a commit that referenced this pull request Oct 4, 2024
* fix: issue with slugs and condition

* fix: issue with badge with global bundle + tests

* chore: update test imports

* test: update createWrapper import

* refactor: update dummygetters to reflect corel
juice49 pushed a commit that referenced this pull request Oct 7, 2024
* fix: issue with slugs and condition

* fix: issue with badge with global bundle + tests

* chore: update test imports

* test: update createWrapper import

* refactor: update dummygetters to reflect corel
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants