-
Notifications
You must be signed in to change notification settings - Fork 451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: move createWrapper to test package, update name -> slug #7177
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
No changes to documentation |
@@ -26,7 +26,7 @@ export function DocumentPerspectiveMenu(props: {documentId: string}): JSX.Elemen | |||
const {currentGlobalBundle} = usePerspective() | |||
const bundles = useMemo(() => data ?? [], [data]) | |||
|
|||
const existsInBundle = bundles.some((bundle) => bundle.slug === getBundleSlug(documentId)) | |||
const existsInBundle = getBundleSlug(documentId) === currentGlobalBundle?.slug |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was the misaligned logic here surfaced by the test by any chance? 👀
Least if it was you can say that all the toil was worth it...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have to admit I don't recall 🥲
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice one @RitaDias.
Great to see just a single, wrapper being used. I'll try reuse this for a few tests I'm adding to the plugin
* fix: issue with slugs and condition * fix: issue with badge with global bundle + tests * chore: update test imports * test: update createWrapper import * refactor: update dummygetters to reflect corel
* fix: issue with slugs and condition * fix: issue with badge with global bundle + tests * chore: update test imports * test: update createWrapper import * refactor: update dummygetters to reflect corel
* fix: issue with slugs and condition * fix: issue with badge with global bundle + tests * chore: update test imports * test: update createWrapper import * refactor: update dummygetters to reflect corel
* fix: issue with slugs and condition * fix: issue with badge with global bundle + tests * chore: update test imports * test: update createWrapper import * refactor: update dummygetters to reflect corel
* fix: issue with slugs and condition * fix: issue with badge with global bundle + tests * chore: update test imports * test: update createWrapper import * refactor: update dummygetters to reflect corel
* fix: issue with slugs and condition * fix: issue with badge with global bundle + tests * chore: update test imports * test: update createWrapper import * refactor: update dummygetters to reflect corel
* fix: issue with slugs and condition * fix: issue with badge with global bundle + tests * chore: update test imports * test: update createWrapper import * refactor: update dummygetters to reflect corel
* fix: issue with slugs and condition * fix: issue with badge with global bundle + tests * chore: update test imports * test: update createWrapper import * refactor: update dummygetters to reflect corel
* fix: issue with slugs and condition * fix: issue with badge with global bundle + tests * chore: update test imports * test: update createWrapper import * refactor: update dummygetters to reflect corel
* fix: issue with slugs and condition * fix: issue with badge with global bundle + tests * chore: update test imports * test: update createWrapper import * refactor: update dummygetters to reflect corel
* fix: issue with slugs and condition * fix: issue with badge with global bundle + tests * chore: update test imports * test: update createWrapper import * refactor: update dummygetters to reflect corel
* fix: issue with slugs and condition * fix: issue with badge with global bundle + tests * chore: update test imports * test: update createWrapper import * refactor: update dummygetters to reflect corel
* fix: issue with slugs and condition * fix: issue with badge with global bundle + tests * chore: update test imports * test: update createWrapper import * refactor: update dummygetters to reflect corel
* fix: issue with slugs and condition * fix: issue with badge with global bundle + tests * chore: update test imports * test: update createWrapper import * refactor: update dummygetters to reflect corel
* fix: issue with slugs and condition * fix: issue with badge with global bundle + tests * chore: update test imports * test: update createWrapper import * refactor: update dummygetters to reflect corel
* fix: issue with slugs and condition * fix: issue with badge with global bundle + tests * chore: update test imports * test: update createWrapper import * refactor: update dummygetters to reflect corel
* fix: issue with slugs and condition * fix: issue with badge with global bundle + tests * chore: update test imports * test: update createWrapper import * refactor: update dummygetters to reflect corel
* fix: issue with slugs and condition * fix: issue with badge with global bundle + tests * chore: update test imports * test: update createWrapper import * refactor: update dummygetters to reflect corel
Description