-
Notifications
You must be signed in to change notification settings - Fork 435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: WebSocket is closed before the connection is established
warning
#7227
Closed
stipsan
wants to merge
1
commit into
next
from
fix-WebSocket-is-closed-before-the-connection-is-established
Closed
fix: WebSocket is closed before the connection is established
warning
#7227
stipsan
wants to merge
1
commit into
next
from
fix-WebSocket-is-closed-before-the-connection-is-established
+14
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
No changes to documentation |
Component Testing Report Updated Aug 29, 2024 9:52 AM (UTC) ❌ Failed Tests (2) -- expand for details
|
stipsan
force-pushed
the
fix-WebSocket-is-closed-before-the-connection-is-established
branch
from
July 29, 2024 08:12
bb62db9
to
0bd30a5
Compare
stipsan
force-pushed
the
fix-WebSocket-is-closed-before-the-connection-is-established
branch
from
July 31, 2024 07:40
0bd30a5
to
e807718
Compare
stipsan
force-pushed
the
fix-WebSocket-is-closed-before-the-connection-is-established
branch
from
August 1, 2024 07:50
e807718
to
7d5915e
Compare
stipsan
force-pushed
the
fix-WebSocket-is-closed-before-the-connection-is-established
branch
from
August 29, 2024 09:36
7d5915e
to
21b3dbc
Compare
auto-merge was automatically disabled
August 29, 2024 09:57
Pull request was closed
stipsan
deleted the
fix-WebSocket-is-closed-before-the-connection-is-established
branch
August 29, 2024 09:57
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In production we have this very annoying warning:
WebSocket connection to 'wss://:projectId.api.sanity.io/v2022-06-30/socket/:dataset?tag=sanity.studio' failed: WebSocket is closed before the connection is established.
Here's both the warning, and the Network tab, showing that a WSS were initiated and discarded:
After moving the
useGlobalPresence
anduseDocumentPresence
hooks touseObservable
fromreact-rx
, the problem is resolved in production:It's not resolved when using
sanity dev
. I'm not sure yet why that is, but I suspect it's a timing problem with the observable in one of its dependencies.The change from
useMemo
touseState
inResourceCacheProvider
is to reduce possible issues in StrictMode as the hook is called twice there: https://react.dev/reference/react/useMemo#my-calculation-runs-twice-on-every-re-renderWhat to review
It makes sense?
Testing
Test that global presence and document presence still works ok (it does on my tests, it's nice with a second pair of eyes).
Notes for release
No longer warns about
WebSocket is closed before the connection is established
in production.