Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): drop use of es2015 target for vite config #7231

Merged
merged 0 commits into from
Jul 23, 2024
Merged

Conversation

RitaDias
Copy link
Contributor

@RitaDias RitaDias commented Jul 23, 2024

Description

Fix issues related to the crashing of media plugin. Somehow using 'es2015' was causing the media plugin to crash when it was attempting to be opened

I'm still adding tests, but for timezones wise I'm keeping this

What to review

Code

Testing

I'll be adding one e2e tests

Changelog

Fixes regression where the image input and media plugin were crashing the input / studio when picked

@RitaDias RitaDias requested a review from a team as a code owner July 23, 2024 14:36
@RitaDias RitaDias requested review from rexxars and ricokahler and removed request for a team and rexxars July 23, 2024 14:36
Copy link

vercel bot commented Jul 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
page-building-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 23, 2024 2:42pm
performance-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 23, 2024 2:42pm
test-compiled-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 23, 2024 2:42pm
test-next-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 23, 2024 2:42pm
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 23, 2024 2:42pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Jul 23, 2024 2:42pm

Copy link
Contributor

@ricokahler ricokahler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you ❤️

Copy link
Contributor

No changes to documentation

Copy link
Contributor

Component Testing Report Updated Jul 23, 2024 2:55 PM (UTC)

File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 44s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 8s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 30s 6 0 0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 37s 11 7 0
formBuilder/inputs/PortableText/copyPaste/CopyPasteFields.spec.tsx ✅ Passed (Inspect) 0s 0 12 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 17s 6 0 0
formBuilder/inputs/PortableText/DisableFocusAndUnset.spec.tsx ✅ Passed (Inspect) 11s 3 0 0
formBuilder/inputs/PortableText/DragAndDrop.spec.tsx ✅ Passed (Inspect) 3m 0s 0 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 44s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 1m 45s 21 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 1m 15s 18 0 0
formBuilder/inputs/PortableText/PresenceCursors.spec.tsx ✅ Passed (Inspect) 9s 3 9 0
formBuilder/inputs/PortableText/RangeDecoration.spec.tsx ✅ Passed (Inspect) 26s 9 0 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 18s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ❌ Failed (Inspect) 1m 36s 19 0 2
formBuilder/tree-editing/TreeEditing.spec.tsx ✅ Passed (Inspect) 1m 47s 30 0 0
formBuilder/tree-editing/TreeEditingNestedObjects.spec.tsx ✅ Passed (Inspect) 20s 3 0 0

@rexxars rexxars changed the title Fix(sanity/cli): issue with media plugins crashing fix(cli): drop use of es2015 target for vite config Jul 23, 2024
@ricokahler ricokahler merged commit 3682286 into next Jul 23, 2024
47 checks passed
@ricokahler ricokahler deleted the sdx-1502 branch July 23, 2024 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants