-
Notifications
You must be signed in to change notification settings - Fork 435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(cli): drop use of es2015 target for vite config #7231
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RitaDias
requested review from
rexxars and
ricokahler
and removed request for
a team and
rexxars
July 23, 2024 14:36
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
ricokahler
approved these changes
Jul 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you ❤️
No changes to documentation |
Component Testing Report Updated Jul 23, 2024 2:55 PM (UTC)
|
rexxars
changed the title
Fix(sanity/cli): issue with media plugins crashing
fix(cli): drop use of es2015 target for vite config
Jul 23, 2024
ricokahler
temporarily deployed
to
npm-production
July 23, 2024 17:03 — with
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix issues related to the crashing of media plugin. Somehow using 'es2015' was causing the media plugin to crash when it was attempting to be opened
I'm still adding tests, but for timezones wise I'm keeping this
What to review
Code
Testing
I'll be adding one e2e tests
Changelog
Fixes regression where the image input and media plugin were crashing the input / studio when picked