Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sanity, test): fix issue with disable action button, update test #7239

Closed
wants to merge 6 commits into from

Conversation

RitaDias
Copy link
Contributor

@RitaDias RitaDias commented Jul 24, 2024

Description

Issue where opening a array editing view, the main action wasn't reactivated
This is related to the focus fix that was done, I have a suggestion but I'm unsure it's the right way to go @hermanwikner

video

What to review

Solution

Testing

  1. Open a document which contain an array of object

  2. Open one of the object and edit a field inside this object

  3. Close the popup

  4. Notice that the button is disabled, even though we updated a field

  5. Notes for release

Fixes issue where opening the beta array editing would keep the publish button disabled

Copy link

vercel bot commented Jul 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
page-building-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 19, 2024 7:21am
performance-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 19, 2024 7:21am
test-compiled-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 19, 2024 7:21am
test-next-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 19, 2024 7:21am
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 19, 2024 7:21am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Visit Preview Aug 19, 2024 7:21am

Copy link
Contributor

No changes to documentation

Copy link
Contributor

github-actions bot commented Jul 24, 2024

Component Testing Report Updated Aug 19, 2024 7:30 AM (UTC)

File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 43s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 8s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 31s 6 0 0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 37s 11 7 0
formBuilder/inputs/PortableText/copyPaste/CopyPasteFields.spec.tsx ✅ Passed (Inspect) 0s 0 12 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 17s 6 0 0
formBuilder/inputs/PortableText/DisableFocusAndUnset.spec.tsx ✅ Passed (Inspect) 10s 3 0 0
formBuilder/inputs/PortableText/DragAndDrop.spec.tsx ✅ Passed (Inspect) 3m 0s 0 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 44s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 1m 48s 21 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 1m 14s 18 0 0
formBuilder/inputs/PortableText/PresenceCursors.spec.tsx ✅ Passed (Inspect) 8s 3 9 0
formBuilder/inputs/PortableText/RangeDecoration.spec.tsx ✅ Passed (Inspect) 26s 9 0 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 18s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 1m 14s 21 0 0
formBuilder/tree-editing/TreeEditing.spec.tsx ❌ Failed (Inspect) 2m 17s 27 0 3
formBuilder/tree-editing/TreeEditingNestedObjects.spec.tsx ✅ Passed (Inspect) 20s 3 0 0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant