-
Notifications
You must be signed in to change notification settings - Fork 440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(sanity): support viewing and editing document versions #7251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
juice49
force-pushed
the
feat/corel-3/multiple-document-versions
branch
from
July 26, 2024 09:19
89dfced
to
9a6f456
Compare
juice49
changed the title
Feat/corel 3/multiple document versions
feat(sanity): support viewing and editing document versions
Jul 26, 2024
juice49
force-pushed
the
feat/corel-3/multiple-document-versions
branch
from
July 29, 2024 08:18
9a6f456
to
9fe8ba4
Compare
juice49
force-pushed
the
feat/corel-3/multiple-document-versions
branch
from
August 12, 2024 13:37
7921fd9
to
e9aa1cd
Compare
juice49
force-pushed
the
feat/corel-3/multiple-document-versions
branch
from
August 12, 2024 14:35
7002e84
to
70b2876
Compare
juice49
force-pushed
the
feat/corel-3/multiple-document-versions
branch
from
August 13, 2024 08:26
cfb603b
to
159b948
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This branch introduces a new, optional,
version
property to document pairs and their various associated constructs. When a bundle is checked out, the version document takes precedence over the published and draft documents. If no version document exists, the draft and published documents are used.This branch also moves the checked-out bundle state up to the structure pane node context. This allows each pane to have its own bundle checked out.
Example multi-version split pane URL:
http://localhost:3333/test/structure/book;243dbfde-e1e0-4289-a72e-445e8926b4d4;243dbfde-e1e0-4289-a72e-445e8926b4d4%2Ctype%3Dbook%2Cperspective%3Dbundle.autumn-drop?perspective=bundle.summer-drop
.I'm wondering whether it might be beneficial to try to get these changes into
next
sooner rather than later.Todo
perspective?.startsWith('bundle.')
and similar in a lot of places. Now might be a good time to to abstract that.DocumentPerspectiveMenu
.getDocumentPairPermissions
.What to review
It would be great to get some thoughts about the general approach taken. Does adding a new
version
property to constructs make sense, instead of reusing the existingdraft
property? My reasons for this decision are:Very open to opposing thoughts!
Testing
Notes for release