fix(core): correctly reset PTE list counts #7286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I was reading the docs on [`counter-reset`](https://developer.mozilla.org/en-US/docs/Web/CSS/counter-reset#description) when this paragraph suddenly stood out: > After creating a counter using `counter-reset`, you can adjust its value by > using the `counter-set` property. This is counterintuitive because, despite > its name, the `counter-reset` property is used for creating and initializing > counters, while the `counter-set` property is used for resetting the value > of an existing counter. This made me realise that we probably used `content-reset` somewhere, incorrectly, where we actually meant to use `counter-set`. Before this change, counters on each list level would not reset at all across a PTE document. Now, the counters reset properly. Before: ``` 1. This a. is i. nested 1. list This is a paragraph 2. This ii. is b. another nested 2. list ``` After: ``` 1. This a. is i. nested 1. list This is a paragraph 1. This i. is a. another nested 1. list ```
christianhg
requested review from
a team and
jordanl17
and removed request for
a team
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
|
No changes to documentation |
|
Component Testing Report Updated Jul 31, 2024 9:03 AM (UTC)
|
cngonzalez
pushed a commit
that referenced
this pull request
Aug 20, 2024
I was reading the docs on [`counter-reset`](https://developer.mozilla.org/en-US/docs/Web/CSS/counter-reset#description) when this paragraph suddenly stood out: > After creating a counter using `counter-reset`, you can adjust its value by > using the `counter-set` property. This is counterintuitive because, despite > its name, the `counter-reset` property is used for creating and initializing > counters, while the `counter-set` property is used for resetting the value > of an existing counter. This made me realise that we probably used `content-reset` somewhere, incorrectly, where we actually meant to use `counter-set`. Before this change, counters on each list level would not reset at all across a PTE document. Now, the counters reset properly. Before: ``` 1. This a. is i. nested 1. list This is a paragraph 2. This ii. is b. another nested 2. list ``` After: ``` 1. This a. is i. nested 1. list This is a paragraph 1. This i. is a. another nested 1. list ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I was reading the docs on
counter-resetwhen this paragraph suddenly stood out:This made me realise that we probably used
content-resetsomewhere, incorrectly, where we actually meant to usecounter-set.Before this change, counters on each list level would not reset at all across a PTE document. Now, the counters reset properly.
Before:
After:
Studio screenshots:
Before:
After:
What to review
If you know of some large documents with lots of content and lists at different levels, then that might be helpful when reviewing if this change has any adverse effects.
Testing
I created various lists in a document broken up by various other elements and visually verified the list counts. Manual testing it the most practical method here.
Notes for release