feat(corel): virtualize content releases plugin lists #7301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
|
No changes to documentation |
pedrobonamin
requested review from
ricokahler,
bjoerge,
juice49 and
a team
and removed request for
a team and
ricokahler
…use the fetched document
bjoerge
pushed a commit
that referenced
this pull request
Aug 16, 2024
* feat(core): virtualise the content releases lists * feat(corel): lift preview values state to useBundles hook * fix(core): update corel sort actions * fix(core): update useBundleDocuments return value * fix(core): rename BundleDocumentResult to DocumentInBundleResult * fix(corel): remove Row prop from releases Table * fix(core): update how preview is calculated in useBundleDocuments, reuse the fetched document * feat(core): update corel summary and overview virtual tables * fix(core): update release summary types import * feat(core): virtualize review changes screen - corel-91
bjoerge
pushed a commit
that referenced
this pull request
Aug 20, 2024
* feat(core): virtualise the content releases lists * feat(corel): lift preview values state to useBundles hook * fix(core): update corel sort actions * fix(core): update useBundleDocuments return value * fix(core): rename BundleDocumentResult to DocumentInBundleResult * fix(corel): remove Row prop from releases Table * fix(core): update how preview is calculated in useBundleDocuments, reuse the fetched document * feat(core): update corel summary and overview virtual tables * fix(core): update release summary types import * feat(core): virtualize review changes screen - corel-91
bjoerge
pushed a commit
that referenced
this pull request
Aug 20, 2024
* feat(core): virtualise the content releases lists * feat(corel): lift preview values state to useBundles hook * fix(core): update corel sort actions * fix(core): update useBundleDocuments return value * fix(core): rename BundleDocumentResult to DocumentInBundleResult * fix(corel): remove Row prop from releases Table * fix(core): update how preview is calculated in useBundleDocuments, reuse the fetched document * feat(core): update corel summary and overview virtual tables * fix(core): update release summary types import * feat(core): virtualize review changes screen - corel-91
bjoerge
pushed a commit
that referenced
this pull request
Aug 20, 2024
* feat(core): virtualise the content releases lists * feat(corel): lift preview values state to useBundles hook * fix(core): update corel sort actions * fix(core): update useBundleDocuments return value * fix(core): rename BundleDocumentResult to DocumentInBundleResult * fix(corel): remove Row prop from releases Table * fix(core): update how preview is calculated in useBundleDocuments, reuse the fetched document * feat(core): update corel summary and overview virtual tables * fix(core): update release summary types import * feat(core): virtualize review changes screen - corel-91
RitaDias
pushed a commit
that referenced
this pull request
Aug 23, 2024
* feat(core): virtualise the content releases lists * feat(corel): lift preview values state to useBundles hook * fix(core): update corel sort actions * fix(core): update useBundleDocuments return value * fix(core): rename BundleDocumentResult to DocumentInBundleResult * fix(corel): remove Row prop from releases Table * fix(core): update how preview is calculated in useBundleDocuments, reuse the fetched document * feat(core): update corel summary and overview virtual tables * fix(core): update release summary types import * feat(core): virtualize review changes screen - corel-91
RitaDias
pushed a commit
that referenced
this pull request
Aug 26, 2024
* feat(core): virtualise the content releases lists * feat(corel): lift preview values state to useBundles hook * fix(core): update corel sort actions * fix(core): update useBundleDocuments return value * fix(core): rename BundleDocumentResult to DocumentInBundleResult * fix(corel): remove Row prop from releases Table * fix(core): update how preview is calculated in useBundleDocuments, reuse the fetched document * feat(core): update corel summary and overview virtual tables * fix(core): update release summary types import * feat(core): virtualize review changes screen - corel-91
juice49
pushed a commit
that referenced
this pull request
Sep 3, 2024
* feat(core): virtualise the content releases lists * feat(corel): lift preview values state to useBundles hook * fix(core): update corel sort actions * fix(core): update useBundleDocuments return value * fix(core): rename BundleDocumentResult to DocumentInBundleResult * fix(corel): remove Row prop from releases Table * fix(core): update how preview is calculated in useBundleDocuments, reuse the fetched document * feat(core): update corel summary and overview virtual tables * fix(core): update release summary types import * feat(core): virtualize review changes screen - corel-91
RitaDias
pushed a commit
that referenced
this pull request
Oct 3, 2024
* feat(core): virtualise the content releases lists * feat(corel): lift preview values state to useBundles hook * fix(core): update corel sort actions * fix(core): update useBundleDocuments return value * fix(core): rename BundleDocumentResult to DocumentInBundleResult * fix(corel): remove Row prop from releases Table * fix(core): update how preview is calculated in useBundleDocuments, reuse the fetched document * feat(core): update corel summary and overview virtual tables * fix(core): update release summary types import * feat(core): virtualize review changes screen - corel-91
juice49
pushed a commit
that referenced
this pull request
Oct 4, 2024
* feat(core): virtualise the content releases lists * feat(corel): lift preview values state to useBundles hook * fix(core): update corel sort actions * fix(core): update useBundleDocuments return value * fix(core): rename BundleDocumentResult to DocumentInBundleResult * fix(corel): remove Row prop from releases Table * fix(core): update how preview is calculated in useBundleDocuments, reuse the fetched document * feat(core): update corel summary and overview virtual tables * fix(core): update release summary types import * feat(core): virtualize review changes screen - corel-91
juice49
pushed a commit
that referenced
this pull request
Oct 7, 2024
* feat(core): virtualise the content releases lists * feat(corel): lift preview values state to useBundles hook * fix(core): update corel sort actions * fix(core): update useBundleDocuments return value * fix(core): rename BundleDocumentResult to DocumentInBundleResult * fix(corel): remove Row prop from releases Table * fix(core): update how preview is calculated in useBundleDocuments, reuse the fetched document * feat(core): update corel summary and overview virtual tables * fix(core): update release summary types import * feat(core): virtualize review changes screen - corel-91
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This branch introduces virtualization for lists in the releases plugin.
Virtualizes the releases summary and the release detail screen lists.
Lifts the preview values, for the documents displayed in the release detail screen , to the
useBundleDocumentshook. This is necessary because we are using the title generated in the preview values to filter the list.With the list virtualization, we need to filter the list before exposing it to the virtualizer, previously, we were not filtering the list, we were just returning null if the row title didn't match the filter criteria.
Removes the
Rowprop from theTable, given it's not necessary anymore and adds extra complexity.Refactors the uses from the data obtained from the
useBundleDocumentshook to avoid unnecessary transformations, like creating the Validation map.Removes
packages/sanity/src/core/releases/tool/detail/bundleDocumentsValidation.tsgiven it's not used.TODO
What to review
Is this correct?
Is there other way to lift the preview values which would be more convenient?
Testing
Existing tests are updated, that should be sufficient to cover the changes introduced.
Notes for release