Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(preview): remove full document preview support #7303

Merged
merged 1 commit into from
Aug 2, 2024

Conversation

bjoerge
Copy link
Member

@bjoerge bjoerge commented Aug 2, 2024

This was an interesting thing to explore, but it doesn't scale well, so turning this off for now (it's only been enabled in this branch, fwiw).

This was an interesting thing to explore, but it doesn't scale well, so turning this off for now.
Copy link

vercel bot commented Aug 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
page-building-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 2, 2024 2:05pm
performance-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 2, 2024 2:05pm
test-compiled-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 2, 2024 2:05pm
test-next-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 2, 2024 2:05pm
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 2, 2024 2:05pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Visit Preview Aug 2, 2024 2:05pm

Copy link
Contributor

github-actions bot commented Aug 2, 2024

No changes to documentation

@@ -21,7 +21,7 @@ export function createGlobalListener(client: SanityClient) {
includeResult: false,
includePreviousRevision: false,
includeMutations: false,
visibility: 'transaction',
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is setting it back to how it was before

Copy link
Contributor

@juice49 juice49 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks! I noticed some E2E tests failed, but it looks like they passed for other browsers, so I assume this is caused by flakiness.

@bjoerge bjoerge merged commit 0e7f106 into corel Aug 2, 2024
38 of 41 checks passed
@bjoerge bjoerge deleted the corel-disable-full-document-previews branch August 2, 2024 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants