chore(typegen): trace overloadClientMethods usage #7326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
|
No changes to documentation |
|
Component Testing Report Updated Aug 6, 2024 12:17 PM (UTC)
|
Comment on lines
13
to
15
| config: { | ||
| overloadClientMethods: boolean | ||
| } |
There was a problem hiding this comment.
Event properties should ideally not be nested. Is it OK to flatten the object by removing the config property and moving overloadClientMethods out?
There was a problem hiding this comment.
Sure. I made it nested since that's how it is here https://github.com/sanity-io/sanity/blob/next/packages/%40sanity/cli/src/__telemetry__/cli.telemetry.ts#L18-L22
sgulseth
force-pushed
the
chore/typegen/trace-overload-client-methods
branch
from
fa68585 to
14c9caf
Compare
joneidejohnsen
approved these changes
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Trace overload client methods usage
What to review
Is the interface ok for consumption in aplitude/bigquery?
Testing
n/a
Notes for release
n/a no notes needed