Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): don't create default apps on deploy #7328

Merged
merged 3 commits into from
Aug 7, 2024
Merged

fix(cli): don't create default apps on deploy #7328

merged 3 commits into from
Aug 7, 2024

Conversation

binoy14
Copy link
Contributor

@binoy14 binoy14 commented Aug 6, 2024

Description

Doesn't create default apps on new CLI version. DM for more context if needed

What to review

Changes make sense, there shouldn't be any instance of isDefaultForDeployment

Testing

Updated

Notes for release

N/A

Copy link

vercel bot commented Aug 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
page-building-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 7, 2024 3:34am
performance-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 7, 2024 3:34am
test-compiled-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 7, 2024 3:34am
test-next-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 7, 2024 3:34am
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 7, 2024 3:34am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Visit Preview Aug 7, 2024 3:34am

Copy link
Contributor Author

binoy14 commented Aug 6, 2024

Copy link
Contributor

github-actions bot commented Aug 6, 2024

No changes to documentation

Copy link
Contributor

github-actions bot commented Aug 6, 2024

Component Testing Report Updated Aug 7, 2024 3:48 AM (UTC)

File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 45s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 8s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 29s 6 0 0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 36s 11 7 0
formBuilder/inputs/PortableText/copyPaste/CopyPasteFields.spec.tsx ✅ Passed (Inspect) 0s 0 12 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 16s 6 0 0
formBuilder/inputs/PortableText/DisableFocusAndUnset.spec.tsx ✅ Passed (Inspect) 10s 3 0 0
formBuilder/inputs/PortableText/DragAndDrop.spec.tsx ✅ Passed (Inspect) 3m 0s 0 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 43s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 1m 39s 21 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 1m 14s 18 0 0
formBuilder/inputs/PortableText/PresenceCursors.spec.tsx ✅ Passed (Inspect) 8s 3 9 0
formBuilder/inputs/PortableText/RangeDecoration.spec.tsx ✅ Passed (Inspect) 25s 9 0 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 17s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 1m 13s 21 0 0
formBuilder/tree-editing/TreeEditing.spec.tsx ✅ Passed (Inspect) 1m 47s 30 0 0
formBuilder/tree-editing/TreeEditingNestedObjects.spec.tsx ✅ Passed (Inspect) 19s 3 0 0

@binoy14 binoy14 merged commit 812e1e3 into sdx-1562 Aug 7, 2024
67 of 69 checks passed
@binoy14 binoy14 deleted the sdx-1565 branch August 7, 2024 03:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant