feat(releases, core): supporting banner display for remote deleted bundles #7371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
|
No changes to documentation |
jordanl17
commented
Aug 14, 2024
There was a problem hiding this comment.
Most of the logic here is a copy from the existing DocumentDeletedBanner and useBundleDeletedToast. However now there is a single entry point - DocumentDeletedBanners (there are 2 banners that might display for a deleted document - bundle deleted, and non-bundle deleted).
A check if done to see if the bundle has been deleted, and then the relevant Banner component is rendered
jordanl17
commented
Aug 14, 2024
| ) | ||
|
|
||
| useEffect(() => { | ||
| if (currentGlobalBundleSlug !== LATEST.slug) { |
There was a problem hiding this comment.
The checkedout bundle slug is the version. Latest ie. draft slug, is not considered checkedout, since it's the default and fallback, so the state value never reflects drafts. This allows for support in cases where usePerspective returns drafts quicker than deletedBundles updates, and in this case the remote deleted bundle would never be tracked and the banner would never be displayed
There was a problem hiding this comment.
Great point, I think that adding a similar comment on the code itself would do us good for the future so we can keep this context :)
There was a problem hiding this comment.
- Comment on the esoteric logic in
DeletedDocumentBanners
jordanl17
force-pushed
the
corel-37-deleted-banner
branch
from
1d121ff to
c0a4232
Compare
|
Component Testing Report Updated Aug 19, 2024 12:13 PM (UTC)
|
jordanl17
force-pushed
the
corel-37-deleted-banner
branch
from
c0a4232 to
2ccf035
Compare
jordanl17
commented
Aug 16, 2024
There was a problem hiding this comment.
Logic and render moved to DeletedDocumentBanners.DeletedDocumentBanner
bjoerge
pushed a commit
that referenced
this pull request
Aug 20, 2024
…ndles (#7371) * feat(releases, core): remote deleted version documents will show as banner instead of toast warning * chore(releases, core): using UI components where available and supported * chore(core, releases): removing padding and using ui-component buttons * tests(structure): adding tests for new deleted document banner consolidation * chore(structure): fixing test imports and mocks
bjoerge
pushed a commit
that referenced
this pull request
Aug 20, 2024
…ndles (#7371) * feat(releases, core): remote deleted version documents will show as banner instead of toast warning * chore(releases, core): using UI components where available and supported * chore(core, releases): removing padding and using ui-component buttons * tests(structure): adding tests for new deleted document banner consolidation * chore(structure): fixing test imports and mocks
bjoerge
pushed a commit
that referenced
this pull request
Aug 20, 2024
…ndles (#7371) * feat(releases, core): remote deleted version documents will show as banner instead of toast warning * chore(releases, core): using UI components where available and supported * chore(core, releases): removing padding and using ui-component buttons * tests(structure): adding tests for new deleted document banner consolidation * chore(structure): fixing test imports and mocks
RitaDias
pushed a commit
that referenced
this pull request
Aug 23, 2024
…ndles (#7371) * feat(releases, core): remote deleted version documents will show as banner instead of toast warning * chore(releases, core): using UI components where available and supported * chore(core, releases): removing padding and using ui-component buttons * tests(structure): adding tests for new deleted document banner consolidation * chore(structure): fixing test imports and mocks
RitaDias
pushed a commit
that referenced
this pull request
Aug 26, 2024
…ndles (#7371) * feat(releases, core): remote deleted version documents will show as banner instead of toast warning * chore(releases, core): using UI components where available and supported * chore(core, releases): removing padding and using ui-component buttons * tests(structure): adding tests for new deleted document banner consolidation * chore(structure): fixing test imports and mocks
juice49
pushed a commit
that referenced
this pull request
Sep 3, 2024
…ndles (#7371) * feat(releases, core): remote deleted version documents will show as banner instead of toast warning * chore(releases, core): using UI components where available and supported * chore(core, releases): removing padding and using ui-component buttons * tests(structure): adding tests for new deleted document banner consolidation * chore(structure): fixing test imports and mocks
RitaDias
pushed a commit
that referenced
this pull request
Oct 3, 2024
…ndles (#7371) * feat(releases, core): remote deleted version documents will show as banner instead of toast warning * chore(releases, core): using UI components where available and supported * chore(core, releases): removing padding and using ui-component buttons * tests(structure): adding tests for new deleted document banner consolidation * chore(structure): fixing test imports and mocks
juice49
pushed a commit
that referenced
this pull request
Oct 4, 2024
…ndles (#7371) * feat(releases, core): remote deleted version documents will show as banner instead of toast warning * chore(releases, core): using UI components where available and supported * chore(core, releases): removing padding and using ui-component buttons * tests(structure): adding tests for new deleted document banner consolidation * chore(structure): fixing test imports and mocks
juice49
pushed a commit
that referenced
this pull request
Oct 7, 2024
…ndles (#7371) * feat(releases, core): remote deleted version documents will show as banner instead of toast warning * chore(releases, core): using UI components where available and supported * chore(core, releases): removing padding and using ui-component buttons * tests(structure): adding tests for new deleted document banner consolidation * chore(structure): fixing test imports and mocks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When you have a document form open for a bundle which is deleted by another user, previously a toast would temporarily show to warn you that the version has been deleted. Now a banner will persist on the document until you navigate away- to make it clear that edits are no longer being applied to where you initially selected:
The exact UX, eg icon/copy/tone are not yet confirmed, but are small fast follows to apply.
What to review
BundleMenutoBundlesMenuto differentiate it fromBundleMenuButton(BundlesMenuis a list of Bundles anyway)setPerspectiveas this was changing quite frequently forcing rerendersuseBundleDeletedToastDeletedBundleBannerto move this warning to a bannerTesting
Updated tests where necessary
Notes for release
N/A