refactor(sanity): add changes to allow for comments in version documents #7404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
|
No changes to documentation |
|
Component Testing Report Updated Aug 27, 2024 9:19 AM (UTC) ✅ All Tests Passed -- expand for details
|
RitaDias
commented
Aug 26, 2024
| @@ -84,7 +83,7 @@ export function useCommentsStore(opts: CommentsStoreOptions): CommentsStoreRetur | |||
| const handleListenerEvent = useCallback( | |||
| async (event: ListenEvent<Record<string, CommentDocument>>) => { | |||
| // Fetch all comments on initial connection | |||
| if (event.type === 'welcome' && !didInitialFetch.current) { | |||
| if (event.type === 'welcome') { | |||
There was a problem hiding this comment.
needed to remove it in order for the comments to be refetched on switching perspectives in a document
Screen.Recording.2024-08-26.at.13.42.37.mov
There was a problem hiding this comment.
Good catch, let's discuss in slack
There was a problem hiding this comment.
Can you ping the other reviewers when you come to a conclusion on this? 🙂
There was a problem hiding this comment.
I'll be making this change 🔜
juice49
reviewed
Aug 27, 2024
packages/sanity/src/structure/panes/document/comments/CommentsWrapper.tsx
Outdated
Show resolved
Hide resolved
juice49
reviewed
Aug 27, 2024
packages/sanity/src/core/comments/context/comments/CommentsProvider.tsx
Outdated
Show resolved
Hide resolved
…ovider for useEditState
…hing between versions
pedrobonamin
approved these changes
Aug 27, 2024
juice49
pushed a commit
that referenced
this pull request
Sep 3, 2024
…nts (#7404) * refactor(sanity): add changes to allow for comments in version documents * refactor(sanity): send version via prop to commentsListItemLayout * docs(sanity): add comments for todo for readonly * refactor(sanity): fix comments * refactor(sanity): reverts changes to the potential ui for the future * chore(sanity): remove "comments support" comment * refactor(sanity): rename document ids and revert change in CommentsProvider for useEditState * refactor(sanity): refactor solution for re-rendering panes when switching between versions
RitaDias
added a commit
that referenced
this pull request
Oct 3, 2024
…nts (#7404) * refactor(sanity): add changes to allow for comments in version documents * refactor(sanity): send version via prop to commentsListItemLayout * docs(sanity): add comments for todo for readonly * refactor(sanity): fix comments * refactor(sanity): reverts changes to the potential ui for the future * chore(sanity): remove "comments support" comment * refactor(sanity): rename document ids and revert change in CommentsProvider for useEditState * refactor(sanity): refactor solution for re-rendering panes when switching between versions
juice49
pushed a commit
that referenced
this pull request
Oct 4, 2024
…nts (#7404) * refactor(sanity): add changes to allow for comments in version documents * refactor(sanity): send version via prop to commentsListItemLayout * docs(sanity): add comments for todo for readonly * refactor(sanity): fix comments * refactor(sanity): reverts changes to the potential ui for the future * chore(sanity): remove "comments support" comment * refactor(sanity): rename document ids and revert change in CommentsProvider for useEditState * refactor(sanity): refactor solution for re-rendering panes when switching between versions
juice49
pushed a commit
that referenced
this pull request
Oct 7, 2024
…nts (#7404) * refactor(sanity): add changes to allow for comments in version documents * refactor(sanity): send version via prop to commentsListItemLayout * docs(sanity): add comments for todo for readonly * refactor(sanity): fix comments * refactor(sanity): reverts changes to the potential ui for the future * chore(sanity): remove "comments support" comment * refactor(sanity): rename document ids and revert change in CommentsProvider for useEditState * refactor(sanity): refactor solution for re-rendering panes when switching between versions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added changes to the comments to allow for version comments to show up when the version is switched to.
Screen.Recording.2024-08-26.at.14.22.02.mov
Added a todo for when the release is "complete", tested out the readOnly and it looks to do what we want. The rest will depend on design