Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sanity): add telemetry for versions #7460

Merged
merged 14 commits into from
Sep 4, 2024
Merged
Show file tree
Hide file tree
Changes from 11 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,77 @@
import {defineEvent} from '@sanity/telemetry'

interface VersionInfo {
/**
* document type that was added
*/
schemaType: string

/**
* the origin of the version created (from a draft or from a version)
*/
documentOrigin: 'draft' | 'version'
}

/**
* When a document (version) is successfully added to a release
* @internal
*/
export const AddedVersion = defineEvent<VersionInfo>({
name: 'Add version of document to release',
version: 1,
description: 'User added a document to a release',
})

/** When a release is successfully created
* @internal
*/
export const CreatedRelease = defineEvent({
name: 'Create release',
version: 1,
description: 'User created a release',
})

/** When a release is successfully updated
* @internal
*/
export const UpdatedRelease = defineEvent({
name: 'Update release',
version: 1,
description: 'User updated a release',
})

/** When a release is successfully deleted
* @internal
*/
export const DeletedRelease = defineEvent({
name: 'Delete release',
version: 1,
description: 'User deleted a release',
})

/** When a release is successfully published
* @internal
*/
export const PublishedRelease = defineEvent({
name: 'Publish release',
version: 1,
description: 'User published a release',
})

/** When a release is successfully archived
* @internal
*/
export const ArchivedRelease = defineEvent({
name: 'Archive release',
version: 1,
description: 'User archived a release',
})

/** When a release is successfully unarchived
* @internal
*/
export const UnarchivedRelease = defineEvent({
name: 'Unarchive release',
version: 1,
description: 'User unarchived a release',
})
Original file line number Diff line number Diff line change
@@ -1,11 +1,13 @@
import {ArrowRightIcon} from '@sanity/icons'
import {useTelemetry} from '@sanity/telemetry/react'
import {Box, Flex, useToast} from '@sanity/ui'
import {type FormEvent, useCallback, useState} from 'react'
import {type FormBundleDocument, useTranslation} from 'sanity'

import {Button, Dialog} from '../../../../ui-components'
import {type BundleDocument} from '../../../store/bundles/types'
import {useBundleOperations} from '../../../store/bundles/useBundleOperations'
import {CreatedRelease, UpdatedRelease} from '../../__telemetry__/releases.telemetry'
import {usePerspective} from '../../hooks/usePerspective'
import {createReleaseId} from '../../util/createReleaseId'
import {BundleForm} from './BundleForm'
Expand All @@ -22,6 +24,7 @@ export function BundleDetailsDialog(props: BundleDetailsDialogProps): JSX.Elemen
const {createBundle, updateBundle} = useBundleOperations()
const formAction = bundle ? 'edit' : 'create'
const {t} = useTranslation()
const telemetry = useTelemetry()

const [value, setValue] = useState((): FormBundleDocument => {
return {
Expand Down Expand Up @@ -56,6 +59,9 @@ export function BundleDetailsDialog(props: BundleDetailsDialogProps): JSX.Elemen
await submit(submitValue)
if (formAction === 'create') {
setPerspective(value._id)
telemetry.log(CreatedRelease)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A thought here, though I'm unsure if this does or doesn't align with our current telemetry strategies elsewhere. But interested in your thoughts - tracking how/where a release is created eg. from the global perspective menu or from within the releases plugin

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's true that might be interesting to know 💡
I'll add it! Thank you for the idea Jordan, great catch!

Copy link
Contributor Author

@RitaDias RitaDias Sep 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added it on 64bf480

I kept the terms as origin: 'structure' | 'release-plugin' because we know that the section where we create releases from the structure tool will likely change where it is (and might not end up in the nav bar as is now) and kept the name simple as release-plugin because I don't think we'll have multiple places where we'll be able to create the release within the plugin (nor do I know if we need that sort of granularity) + with the re-design it might not be in the "overview" :)

Thoughts are welcome!

} else {
telemetry.log(UpdatedRelease)
}
} catch (err) {
console.error(err)
Expand All @@ -69,7 +75,7 @@ export function BundleDetailsDialog(props: BundleDetailsDialogProps): JSX.Elemen
onSubmit()
}
},
[value, submit, formAction, setPerspective, toast, onSubmit],
[value, submit, formAction, setPerspective, telemetry, toast, onSubmit],
)

const handleOnChange = useCallback((changedValue: FormBundleDocument) => {
Expand Down
Original file line number Diff line number Diff line change
@@ -1,18 +1,21 @@
import {AddIcon, CheckmarkIcon} from '@sanity/icons'
import {useTelemetry} from '@sanity/telemetry/react'
import {useToast} from '@sanity/ui'
import {type ReactNode, useCallback, useState} from 'react'
import {filter, firstValueFrom} from 'rxjs'
import {
getPublishedId,
getVersionFromId,
getVersionId,
isVersionId,
useDocumentOperation,
useDocumentStore,
useTranslation,
} from 'sanity'

import {Button} from '../../../../ui-components'
import {type BundleDocument} from '../../../store/bundles/types'
import {AddedVersion} from '../../__telemetry__/releases.telemetry'

interface BundleActionsProps {
currentGlobalBundle: BundleDocument
Expand Down Expand Up @@ -42,6 +45,7 @@ export function BundleActions(props: BundleActionsProps): ReactNode {
const toast = useToast()
const {newVersion} = useDocumentOperation(publishedId, documentType, bundleId)
const {t} = useTranslation()
const telemetry = useTelemetry()

const handleAddVersion = useCallback(async () => {
if (!documentId) {
Expand All @@ -67,7 +71,7 @@ export function BundleActions(props: BundleActionsProps): ReactNode {
// set up the listener before executing
const createVersionSuccess = firstValueFrom(
documentStore.pair
.operationEvents(versionId, documentType)
.operationEvents(getPublishedId(documentId), documentType)
RitaDias marked this conversation as resolved.
Show resolved Hide resolved
.pipe(filter((e) => e.op === 'newVersion' && e.type === 'success')),
)

Expand All @@ -76,7 +80,21 @@ export function BundleActions(props: BundleActionsProps): ReactNode {
// only change if the version was created successfully
await createVersionSuccess
setIsInVersion(true)
}, [documentId, globalBundleId, documentStore.pair, documentType, newVersion, toast, title])

telemetry.log(AddedVersion, {
schemaType: documentType,
documentOrigin: isVersionId(documentId) ? 'version' : 'draft',
})
}, [
documentId,
globalBundleId,
documentStore.pair,
documentType,
newVersion,
telemetry,
toast,
title,
])

/** TODO what should happen when you add a version if we don't have the ready button */

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,17 @@ import {
TrashIcon,
UnarchiveIcon,
} from '@sanity/icons'
import {useTelemetry} from '@sanity/telemetry/react'
import {Menu, Spinner, Text, useToast} from '@sanity/ui'
import {useState} from 'react'
import {useRouter} from 'sanity/router'

import {Button, Dialog, MenuButton, MenuItem} from '../../../../ui-components'
import {
ArchivedRelease,
DeletedRelease,
UnarchivedRelease,
} from '../../../bundles/__telemetry__/releases.telemetry'
import {BundleDetailsDialog} from '../../../bundles/components/dialog/BundleDetailsDialog'
import {Translate, useTranslation} from '../../../i18n'
import {type BundleDocument} from '../../../store/bundles/types'
Expand All @@ -33,6 +39,7 @@ export const BundleMenuButton = ({disabled, bundle, documentCount}: BundleMenuBu
const bundleMenuDisabled = !bundle || disabled
const toast = useToast()
const {t} = useTranslation(releasesLocaleNamespace)
const telemetry = useTelemetry()

const resetSelectedAction = () => setSelectedAction(undefined)

Expand All @@ -41,6 +48,7 @@ export const BundleMenuButton = ({disabled, bundle, documentCount}: BundleMenuBu
try {
setDiscardStatus('discarding')
await deleteBundle(bundle)
telemetry.log(DeletedRelease)
toast.push({
closable: true,
status: 'success',
Expand Down Expand Up @@ -74,6 +82,12 @@ export const BundleMenuButton = ({disabled, bundle, documentCount}: BundleMenuBu
...bundle,
archivedAt: isBundleArchived ? undefined : new Date().toISOString(),
})

if (isBundleArchived) {
telemetry.log(UnarchivedRelease)
} else {
telemetry.log(ArchivedRelease)
}
RitaDias marked this conversation as resolved.
Show resolved Hide resolved
setIsPerformingOperation(false)
}

Expand Down
Original file line number Diff line number Diff line change
@@ -1,9 +1,11 @@
import {ErrorOutlineIcon, PublishIcon} from '@sanity/icons'
import {useTelemetry} from '@sanity/telemetry/react'
import {Flex, Text, useToast} from '@sanity/ui'
import {useCallback, useMemo, useState} from 'react'
import {type BundleDocument} from 'sanity'

import {Button, Dialog} from '../../../../ui-components'
import {PublishedRelease} from '../../../bundles/__telemetry__/releases.telemetry'
import {Translate, useTranslation} from '../../../i18n'
import {useBundleOperations} from '../../../store/bundles/useBundleOperations'
import {releasesLocaleNamespace} from '../../i18n'
Expand All @@ -24,6 +26,7 @@ export const ReleasePublishAllButton = ({
const toast = useToast()
const {publishBundle} = useBundleOperations()
const {t} = useTranslation(releasesLocaleNamespace)
const telemetry = useTelemetry()
const [publishBundleStatus, setPublishBundleStatus] = useState<'idle' | 'confirm' | 'publishing'>(
'idle',
)
Expand All @@ -47,6 +50,7 @@ export const ReleasePublishAllButton = ({
bundleDocuments.map(({document}) => document),
publishedDocumentsRevisions,
)
telemetry.log(PublishedRelease)
toast.push({
closable: true,
status: 'success',
Expand All @@ -69,7 +73,7 @@ export const ReleasePublishAllButton = ({
} finally {
setPublishBundleStatus('idle')
}
}, [bundle, bundleDocuments, publishBundle, publishedDocumentsRevisions, t, toast])
}, [bundle, bundleDocuments, publishBundle, publishedDocumentsRevisions, t, telemetry, toast])

const confirmPublishDialog = useMemo(() => {
if (publishBundleStatus === 'idle') return null
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ import {usePaneRouter} from '../../components'
import {structureLocaleNamespace} from '../../i18n'
import {type PaneMenuItem} from '../../types'
import {useStructureTool} from '../../useStructureTool'
import {DocumentURLCopied} from './__telemetry__'
import {CreatedDraft, DocumentURLCopied} from './__telemetry__'
import {
DEFAULT_MENU_ITEM_GROUPS,
EMPTY_PARAMS,
Expand Down Expand Up @@ -328,6 +328,10 @@ export const DocumentPaneProvider = memo((props: DocumentPaneProviderProps) => {
})

patchRef.current = (event: PatchEvent) => {
// when creating a new draft
if (!editState.draft && !editState.published && !editState.version) {
Copy link
Contributor Author

@RitaDias RitaDias Sep 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The first section !editState.draft && !editState.published is going to disappear because it's being pushed to next #7459

telemetry.log(CreatedDraft)
}
patch.execute(toMutationPatches(event.patches), initialValue.value)
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,3 +8,13 @@ export const DocumentURLCopied = defineEvent({
version: 1,
description: 'User copied document URL to clipboard',
})

/**
* When a draft is successfully created
* @internal
*/
export const CreatedDraft = defineEvent({
name: 'Create a new draft',
version: 1,
description: 'User created a new draft',
})
Loading