Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: forward onItemPrepend/onItemAppend to ArrayFunctions #7516

Merged
merged 1 commit into from
Sep 17, 2024
Merged

Conversation

bjoerge
Copy link
Member

@bjoerge bjoerge commented Sep 16, 2024

Description

All array inputs are passed onItemPrepend and onItemAppend that they can call to append and prepend items. Still, the default array input(s) defines their own internal handlers for these two events and passes them on to the ArrayFunctions component. This is both unneccesary, and also makes it harder to customize the behavior by passing in a different onItemAppend function to the array input. This PR removes the redundant handleItemPrepend/handleItemAppend handlers in the standard array inputs.

What to review

Does the changes make sense?
I also additionally refactored the internal append/prepend handlers so they build upon the default insertion handler and aligned some naming with current convention (e.g. changed from handleAppendItem to handleItemAppend)

Testing

There should not be any significant differences to how this works today, and existing tests should catch any regressions.

Notes for release

  • Array input now forwards the received onItemPrepend and onItemAppend to the insert button/Array Functions component

@bjoerge bjoerge requested a review from a team as a code owner September 16, 2024 15:39
@bjoerge bjoerge requested review from ricokahler and removed request for a team September 16, 2024 15:39
Copy link

vercel bot commented Sep 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
page-building-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 16, 2024 3:39pm
performance-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 16, 2024 3:39pm
test-compiled-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 16, 2024 3:39pm
test-next-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 16, 2024 3:39pm
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 16, 2024 3:39pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Sep 16, 2024 3:39pm

Copy link
Contributor

No changes to documentation

@bjoerge bjoerge changed the title fix: forward received onItemPrepend/onItemAppend to ArrayFunctions fix: forward onItemPrepend/onItemAppend to ArrayFunctions Sep 16, 2024
Copy link
Contributor

Component Testing Report Updated Sep 16, 2024 3:54 PM (UTC)

✅ All Tests Passed -- expand for details
File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 44s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 8s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 30s 6 0 0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 37s 11 7 0
formBuilder/inputs/PortableText/copyPaste/CopyPasteFields.spec.tsx ✅ Passed (Inspect) 0s 0 12 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 18s 6 0 0
formBuilder/inputs/PortableText/DisableFocusAndUnset.spec.tsx ✅ Passed (Inspect) 10s 3 0 0
formBuilder/inputs/PortableText/DragAndDrop.spec.tsx ✅ Passed (Inspect) 3m 0s 0 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 44s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 1m 45s 21 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 1m 16s 18 0 0
formBuilder/inputs/PortableText/PresenceCursors.spec.tsx ✅ Passed (Inspect) 8s 3 9 0
formBuilder/inputs/PortableText/RangeDecoration.spec.tsx ✅ Passed (Inspect) 26s 9 0 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 19s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 36s 12 0 0
formBuilder/tree-editing/TreeEditing.spec.tsx ✅ Passed (Inspect) 0s 0 3 0
formBuilder/tree-editing/TreeEditingNestedObjects.spec.tsx ✅ Passed (Inspect) 0s 0 3 0

@bjoerge bjoerge added this pull request to the merge queue Sep 17, 2024
Merged via the queue into next with commit 4a50023 Sep 17, 2024
42 checks passed
@bjoerge bjoerge deleted the sdx-1629 branch September 17, 2024 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants