-
Notifications
You must be signed in to change notification settings - Fork 435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add groq2024
search strategy
#7838
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
6373764
to
f981f9b
Compare
No changes to documentation |
Component Testing Report Updated Dec 10, 2024 10:01 AM (UTC) ✅ All Tests Passed -- expand for details
|
⚡️ Editor Performance ReportUpdated Tue, 10 Dec 2024 10:03:18 GMT
Detailed information🏠 Reference resultThe performance result of
🧪 Experiment resultThe performance result of this branch
📚 Glossary
|
f981f9b
to
906f2a7
Compare
906f2a7
to
6011c15
Compare
6011c15
to
29e48e7
Compare
d1f7245
to
eab0860
Compare
67dbbf8
to
8870071
Compare
packages/sanity/src/core/studio/components/navbar/search/contexts/search/reducer.ts
Show resolved
Hide resolved
It's only necessary to deduplicate search results when using the Text Search API, because this API sometimes produces duplicate results at page boundaries.
Search results now only fade out when input parameters change, reflecting that the results that have already been loaded no longer match the input parameters. They no longer fade out when fetching more results for the same set of input parameters.
8870071
to
0ba6a91
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this @juice49 !
Tests are really helpful to understand the changes.
It looks good to me!
Thanks, @pedrobonamin 🙏. |
Description
This branch introduces a new search strategy:
groq2024
. This strategy adopts GROQ's newtext::query
function and ability to match all text content inside an object using@ match text::query($query)
. This enables dataset search without necessitating every searchable path in the schema is serialised and included in the search request (as is the case withgroqLegacy
search).This experimental strategy is being added to Studio behind a flag so that interested users can help us test it, before it hopefully graduates to being the default search strategy.
To enable this strategy, set
search.strategy
to"groq2024"
inside the Studio config.What to review
groq2024
. You can try it out using any search surface (global search, document lists, and reference search).groq2024
?Testing