feat: use eslint 9 for new studios #7978

rexxars · 2024-12-07T02:09:03Z

Description

Depends on sanity-io/eslint-config-studio#41

Bootstrap new studios with ESLint 9 and the new version of the studio ESLint configuration.

Part of SAPP-1961
Part of SAPP-1690

What to review

Bootstrapped files look correct

Testing

Should be able to test this out by building and bootstrapping a new studio, but changes are also small enough that upgrading and replacing the config file as per the PR will let you test this out

Notes for release

Use ESLint 9 for new studios

vercel · 2024-12-07T02:09:08Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
page-building-studio	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Dec 10, 2024 10:14am
performance-studio	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Dec 10, 2024 10:14am
test-next-studio	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Dec 10, 2024 10:14am
test-studio	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Dec 10, 2024 10:14am

1 Skipped Deployment

Name	Status	Preview	Comments	Updated (UTC)
studio-workshop	⬜️ Ignored (Inspect)	Visit Preview		Dec 10, 2024 10:14am

github-actions · 2024-12-07T02:09:51Z

No changes to documentation

github-actions · 2024-12-07T02:15:53Z

Component Testing Report Updated Dec 10, 2024 10:09 AM (UTC)

✅ All Tests Passed -- expand for details

File	Status	Duration	Passed	Skipped
comments/CommentInput.spec.tsx	✅ Passed (Inspect)	1m 16s	15	0
formBuilder/ArrayInput.spec.tsx	✅ Passed (Inspect)	14s	3	0
formBuilder/inputs/PortableText/Annotations.spec.tsx	✅ Passed (Inspect)	42s	6	0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx	✅ Passed (Inspect)	1m 0s	11	7
formBuilder/inputs/PortableText/copyPaste/CopyPasteFields.spec.tsx	✅ Passed (Inspect)	0s	0	12
formBuilder/inputs/PortableText/Decorators.spec.tsx	✅ Passed (Inspect)	31s	6	0
formBuilder/inputs/PortableText/DisableFocusAndUnset.spec.tsx	✅ Passed (Inspect)	16s	3	0
formBuilder/inputs/PortableText/DragAndDrop.spec.tsx	✅ Passed (Inspect)	2m 9s	2	0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx	✅ Passed (Inspect)	1m 20s	15	0
formBuilder/inputs/PortableText/Input.spec.tsx	✅ Passed (Inspect)	3m 4s	21	0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx	✅ Passed (Inspect)	1m 56s	18	0
formBuilder/inputs/PortableText/PresenceCursors.spec.tsx	✅ Passed (Inspect)	17s	3	9
formBuilder/inputs/PortableText/RangeDecoration.spec.tsx	✅ Passed (Inspect)	46s	9	0
formBuilder/inputs/PortableText/Styles.spec.tsx	✅ Passed (Inspect)	30s	6	0
formBuilder/inputs/PortableText/Toolbar.spec.tsx	✅ Passed (Inspect)	1m 5s	12	0
formBuilder/tree-editing/TreeEditing.spec.tsx	✅ Passed (Inspect)	0s	0	3
formBuilder/tree-editing/TreeEditingNestedObjects.spec.tsx	✅ Passed (Inspect)	0s	0	3

github-actions · 2024-12-07T02:21:16Z

⚡️ Editor Performance Report

Updated Tue, 10 Dec 2024 10:10:56 GMT

Benchmark	reference ^{latency of sanity@latest}	experiment ^{latency of this branch}	Δ (%) ^{latency difference}
article (title)	27.8 efps (36ms)	24.7 efps (41ms)	+5ms (+12.5%)	✅
article (body)	67.3 efps (15ms)	72.2 efps (14ms)	-1ms (-/-%)	✅
article (string inside object)	27.0 efps (37ms)	26.3 efps (38ms)	+1ms (+2.7%)	✅
article (string inside array)	26.3 efps (38ms)	22.7 efps (44ms)	+6ms (+15.8%)	✅
recipe (name)	55.6 efps (18ms)	50.0 efps (20ms)	+2ms (+11.1%)	✅
recipe (description)	62.5 efps (16ms)	55.6 efps (18ms)	+2ms (+12.5%)	✅
recipe (instructions)	99.9+ efps (5ms)	99.9+ efps (5ms)	+0ms (-/-%)	✅
synthetic (title)	19.2 efps (52ms)	18.2 efps (55ms)	+3ms (+5.8%)	✅
synthetic (string inside object)	19.6 efps (51ms)	19.2 efps (52ms)	+1ms (+2.0%)	✅

efps — editor "frames per second". The number of updates assumed to be possible within a second.

Derived from input latency. efps = 1000 / input_latency

Detailed information

🏠 Reference result

The performance result of sanity@latest

Benchmark	latency	p75	p90	p99	blocking time	test duration
article (title)	36ms	39ms	41ms	68ms	270ms	12.1s
article (body)	15ms	17ms	19ms	75ms	59ms	5.1s
article (string inside object)	37ms	40ms	44ms	163ms	143ms	6.7s
article (string inside array)	38ms	40ms	43ms	142ms	145ms	6.7s
recipe (name)	18ms	19ms	21ms	40ms	0ms	8.1s
recipe (description)	16ms	18ms	20ms	32ms	0ms	4.4s
recipe (instructions)	5ms	7ms	9ms	17ms	0ms	3.0s
synthetic (title)	52ms	55ms	59ms	89ms	151ms	12.3s
synthetic (string inside object)	51ms	62ms	80ms	503ms	1090ms	9.3s

🧪 Experiment result

The performance result of this branch

Benchmark	latency	p75	p90	p99	blocking time	test duration
article (title)	41ms	43ms	50ms	167ms	181ms	11.0s
article (body)	14ms	16ms	21ms	64ms	188ms	5.1s
article (string inside object)	38ms	40ms	47ms	71ms	152ms	6.6s
article (string inside array)	44ms	47ms	49ms	195ms	166ms	7.0s
recipe (name)	20ms	21ms	24ms	48ms	0ms	8.3s
recipe (description)	18ms	19ms	22ms	33ms	0ms	4.5s
recipe (instructions)	5ms	6ms	8ms	21ms	0ms	3.1s
synthetic (title)	55ms	57ms	62ms	140ms	638ms	13.9s
synthetic (string inside object)	52ms	55ms	64ms	272ms	662ms	8.2s

📚 Glossary

column definitions

benchmark — the name of the test, e.g. "article", followed by the label of the field being measured, e.g. "(title)".

latency — the time between when a key was pressed and when it was rendered. derived from a set of samples. the median (p50) is shown to show the most common latency.

p75 — the 75th percentile of the input latency in the test run. 75% of the sampled inputs in this benchmark were processed faster than this value. this provides insight into the upper range of typical performance.

p90 — the 90th percentile of the input latency in the test run. 90% of the sampled inputs were faster than this. this metric helps identify slower interactions that occurred less frequently during the benchmark.

p99 — the 99th percentile of the input latency in the test run. only 1% of sampled inputs were slower than this. this represents the worst-case scenarios encountered during the benchmark, useful for identifying potential performance outliers.

blocking time — the total time during which the main thread was blocked, preventing user input and UI updates. this metric helps identify performance bottlenecks that may cause the interface to feel unresponsive.

test duration — how long the test run took to complete.

bjoerge

Thank you <3

* next: (49 commits) fix: delays rendering the Start in Create banner until document is ready (#8020) fix(deps): update dependency @sanity/ui to ^2.10.9 (#8009) chore(deps): dedupe pnpm-lock.yaml (#8023) test(playwright-ct): fix issues and flake (#8016) feat(cli): misc copy changes (#8003) feat(cli): remove is-builtin-module (#6579) v3.67.1 chore(deps): bump minimum requirement of @sanity/import and @sanity/export (#8012) chore(deps): update dependency @sanity/pkg-utils to v6.12.0 (#8010) fix(core): tasks UpdatedTimeAgo should be a hook (#8011) v3.67.0 chore(prettier): fix unformatted files 🤖 ✨ (#8006) chore: reduce renovate double PR noise fix(deps): update dependency @sanity/ui to ^2.10.7 (#8005) fix(deps): update dependency @sanity/ui to ^2.10.7 (#7998) feat(cli): use `@vercel/frameworks` in `bootstrapRemoteTemplate` (#8001) feat: switch create integration to opt-out flow (#8002) feat: use eslint 9 for new studios (#7978) fix(sanity): optimise getLeafWeights to not stack overflow (#7999) feat(test-studio): enable `groq2024` search strategy ...

rexxars requested a review from a team as a code owner December 7, 2024 02:09

rexxars requested review from ryanbonial and removed request for a team December 7, 2024 02:09

vercel bot deployed to Preview – page-building-studio December 7, 2024 02:10 View deployment

vercel bot deployed to Preview – performance-studio December 7, 2024 02:11 View deployment

vercel bot deployed to Preview – test-studio December 7, 2024 02:12 View deployment

vercel bot deployed to Preview – test-next-studio December 7, 2024 02:19 View deployment

rexxars requested a review from bjoerge December 9, 2024 17:17

feat: use eslint 9 for new studios

d38be81

bjoerge force-pushed the feat/eslint-9-studio-config branch from 0d609b4 to d38be81 Compare December 10, 2024 09:58

bjoerge approved these changes Dec 10, 2024

View reviewed changes

vercel bot deployed to Preview – page-building-studio December 10, 2024 10:04 View deployment

vercel bot deployed to Preview – performance-studio December 10, 2024 10:06 View deployment

vercel bot deployed to Preview – test-studio December 10, 2024 10:06 View deployment

vercel bot deployed to Preview – test-next-studio December 10, 2024 10:14 View deployment

bjoerge added this pull request to the merge queue Dec 10, 2024

Merged via the queue into next with commit 30d8f7e Dec 10, 2024
57 checks passed

bjoerge deleted the feat/eslint-9-studio-config branch December 10, 2024 12:25

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: use eslint 9 for new studios #7978

feat: use eslint 9 for new studios #7978

rexxars commented Dec 7, 2024 •

edited

Loading

vercel bot commented Dec 7, 2024 •

edited

Loading

github-actions bot commented Dec 7, 2024

github-actions bot commented Dec 7, 2024 •

edited

Loading

github-actions bot commented Dec 7, 2024 •

edited

Loading

🏠 Reference result

🧪 Experiment result

📚 Glossary

column definitions

bjoerge left a comment

feat: use eslint 9 for new studios #7978

feat: use eslint 9 for new studios #7978

Conversation

rexxars commented Dec 7, 2024 • edited Loading

Description

What to review

Testing

Notes for release

vercel bot commented Dec 7, 2024 • edited Loading

github-actions bot commented Dec 7, 2024

github-actions bot commented Dec 7, 2024 • edited Loading

github-actions bot commented Dec 7, 2024 • edited Loading

⚡️ Editor Performance Report

🏠 Reference result

🧪 Experiment result

📚 Glossary

column definitions

bjoerge left a comment

Choose a reason for hiding this comment

rexxars commented Dec 7, 2024 •

edited

Loading

vercel bot commented Dec 7, 2024 •

edited

Loading

github-actions bot commented Dec 7, 2024 •

edited

Loading

github-actions bot commented Dec 7, 2024 •

edited

Loading